diff options
| author | EuAndreh <eu@euandre.org> | 2021-03-06 18:41:39 -0300 |
|---|---|---|
| committer | EuAndreh <eu@euandre.org> | 2021-03-06 18:41:39 -0300 |
| commit | e411042c0e0f1494e441600e280b9ea5e8ce80b4 (patch) | |
| tree | a1b91b238369ce1db36299e24f1f169d6c7646f8 | |
| parent | src/remembering.c: Include <fallible/string.h> (diff) | |
| download | remembering-e411042c0e0f1494e441600e280b9ea5e8ce80b4.tar.gz remembering-e411042c0e0f1494e441600e280b9ea5e8ce80b4.tar.xz | |
src/remembering.c: Use strdup over malloc+strcpy
| -rw-r--r-- | src/remembering.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/remembering.c b/src/remembering.c index d729b0d..d82f73e 100644 --- a/src/remembering.c +++ b/src/remembering.c @@ -498,18 +498,15 @@ int get_profile(struct GetlineParams *s_params, struct GetlineParams *p_params, if (p_params->read == -1) { while ((s_params->read = getline(&s_params->line, &s_params->len, s_params->stream)) != -1) { - int len = strlen(s_params->line) + 1; - char *s_value_copy = malloc(len); + char *s_value_copy = strdup(s_params->line); if (!s_value_copy) { return -1; } - char *p_value_copy = malloc(len); + char *p_value_copy = strdup(s_params->line); if (!p_value_copy) { free(s_value_copy); return -1; } - strcpy(s_value_copy, s_params->line); - strcpy(p_value_copy, s_params->line); int ret; if ((ret = rankings_insert(s_rankings, s_value_copy, 0)) == -1) { |