| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | overhaul optimized x86_64 memset asm•••on most cpu models, "rep stosq" has high overhead that makes it
undesirable for small memset sizes. the new code extends the
minimal-branch fast path for short memsets from size 15 up to size
126, and shrink-wraps this code path. in addition, "rep stosq" is
sensitive to misalignment. the cost varies with size and with cpu
model, but it has been observed performing 1.5 times slower when the
destination address is not aligned mod 16. the new code thus ensures
alignment mod 16, but also preserves any existing additional
alignment, in case there are cpu models where it is beneficial.
this version is based in part on changes proposed by Denys Vlasenko.
| Rich Felker | 2015-02-26 | 1 | -26/+55 |
| * | overhaul optimized i386 memset asm•••on most cpu models, "rep stosl" has high overhead that makes it
undesirable for small memset sizes. the new code extends the
minimal-branch fast path for short memsets from size 15 up to size 62,
and shrink-wraps this code path. in addition, "rep stosl" is very
sensitive to misalignment. the cost varies with size and with cpu
model, but it has been observed performing 1.5 to 4 times slower when
the destination address is not aligned mod 16. the new code thus
ensures alignment mod 16, but also preserves any existing additional
alignment, in case there are cpu models where it is beneficial.
this version is based in part on changes to the x86_64 memset asm
proposed by Denys Vlasenko.
| Rich Felker | 2015-02-26 | 1 | -32/+61 |
| * | getloadavg: use sysinfo() instead of /proc/loadavg•••Based on a patch by Szabolcs Nagy.
| Alexander Monakov | 2015-02-25 | 1 | -11/+7 |
| * | fix possible isatty false positives and unwanted device state changes•••the equivalent checks for newly opened stdio output streams, used to
determine buffering mode, are also fixed.
on most archs, the TCGETS ioctl command shares a value with
SNDCTL_TMR_TIMEBASE, part of the OSS sound API which was apparently
used with certain MIDI and timer devices. for file descriptors
referring to such a device, TCGETS will not fail with ENOTTY as
expected; it may produce a different error, or may succeed, and if it
succeeds it changes the mode of the device. while it's unlikely that
such devices are in use, this is in principle very harmful behavior
for an operation which is supposed to do nothing but query whether the
fd refers to a tty.
TIOCGWINSZ, used to query logical window size for a terminal, was
chosen as an alternate ioctl to perform the isatty check. it does not
share a value with any other ioctl commands, and it succeeds on any
tty device.
this change also cleans up strace output to be less ugly and
misleading.
| Rich Felker | 2015-02-23 | 3 | -9/+8 |
| * | fix breakage in pthread_cond_wait due to typo•••due to accidental use of = instead of ==, the error code was always
set to zero in the signaled wake case for non-shared cv waits.
suppressing ETIMEDOUT (the only possible wait error) is harmless and
actually permitted in this case, but suppressing mutex errors could
give the caller false information about the state of the mutex.
commit 8741ffe625363a553e8f509dc3ca7b071bdbab47 introduced this
regression and commit d9da1fb8c592469431c764732d09f7756340190e
preserved it when reorganizing the code.
| Rich Felker | 2015-02-23 | 1 | -1/+1 |
| * | support alternate backends for the passwd and group dbs•••when we fail to find the entry in the commonly accepted files, we
query a server over a Unix domain socket on /var/run/nscd/socket.
the protocol used here is compatible with glibc's nscd protocol on
most systems (all that use 32-bit numbers for all the protocol fields,
which appears to be everything but Alpha).
| Josiah Worcester | 2015-02-23 | 4 | -2/+390 |
| * | fix spurious errors in refactored passwd/group code•••errno was treated as the error status when the return value of getline
was negative, but this condition can simply indicate EOF and is not
necessarily an error.
the spurious errors caused by this bug masked the bug which was fixed
in commit fc5a96c9c8aa186effad7520d5df6b616bbfd29d.
| Rich Felker | 2015-02-23 | 2 | -2/+2 |
| * | fix crashes in refactored passwd/group code•••the wrong condition was used in determining the presence of a result
that needs space/copying for the _r functions. a zero return value
does not necessarily mean success; it can also be a non-error negative
result: no such user/group.
| Rich Felker | 2015-02-23 | 2 | -4/+4 |
| * | simplify cond var code now that cleanup handler is not needed | Rich Felker | 2015-02-22 | 1 | -86/+63 |
| * | fix pthread_cond_wait cancellation race•••it's possible that signaling a waiter races with cancellation of that
same waiter. previously, cancellation was acted upon, causing the
signal to be consumed with no waiter returning. by using the new
masked cancellation state, it's possible to refuse to act on the
cancellation request and instead leave it pending.
to ease review and understanding of the changes made, this commit
leaves the unwait function, which was previously the cancellation
cleanup handler, in place. additional simplifications could be made by
removing it.
| Rich Felker | 2015-02-22 | 1 | -5/+38 |
| * | add new masked cancellation mode•••this is a new extension which is presently intended only for
experimental and internal libc use. interface and behavior details may
change subject to feedback and experience from using it internally.
the basic concept for the new PTHREAD_CANCEL_MASKED state is that the
first cancellation point to observe the cancellation request fails
with an errno value of ECANCELED rather than acting on cancellation,
allowing the caller to process the status and choose whether/how to
act upon it.
| Rich Felker | 2015-02-21 | 2 | -10/+16 |
| * | prepare cancellation syscall asm for possibility of __cancel returning | Rich Felker | 2015-02-20 | 5 | -11/+32 |
| * | map interruption of close by signal to success rather than EINPROGRESS•••commit 82dc1e2e783815e00a90cd3f681436a80d54a314 addressed the
resolution of Austin Group issue 529, which requires close to leave
the fd open when failing with EINTR, by returning the newly defined
error code EINPROGRESS. this turns out to be a bad idea, though, since
legacy applications not aware of the new specification are likely to
interpret any error from close except EINTR as a hard failure.
| Rich Felker | 2015-02-20 | 1 | -1/+1 |
| * | make pthread_exit responsible for disabling cancellation•••this requirement is tucked away in XSH 2.9.5 Thread Cancellation under
the heading Thread Cancellation Cleanup Handlers.
| Rich Felker | 2015-02-16 | 2 | -3/+2 |
| * | fix type error (arch-dependent) in new aio code•••a_store is only valid for int, but ssize_t may be defined as long or
another type. since there is no valid way for another thread to acess
the return value without first checking the error/completion status of
the aiocb anyway, an atomic store is not necessary.
| Rich Felker | 2015-02-14 | 1 | -1/+1 |
| * | refactor group file access code•••this allows getgrnam and getgrgid to share code with the _r versions
in preparation for alternate backend support.
| Josiah Worcester | 2015-02-13 | 6 | -51/+71 |
| * | overhaul aio implementation for correctness•••previously, aio operations were not tracked by file descriptor; each
operation was completely independent. this resulted in non-conforming
behavior for non-seekable/append-mode writes (which are required to be
ordered) and made it impossible to implement aio_cancel, which in turn
made closing file descriptors with outstanding aio operations unsafe.
the new implementation is significantly heavier (roughly twice the
size, and seems to be slightly slower) and presently aims mainly at
correctness, not performance.
most of the public interfaces have been moved into a single file,
aio.c, because there is little benefit to be had from splitting them.
whenever any aio functions are used, aio_cancel and the internal
queue lifetime management and fd-to-queue mapping code must be linked,
and these functions make up the bulk of the code size.
the close function's interaction with aio is implemented with weak
alias magic, to avoid pulling in heavy aio cancellation code in
programs that don't use aio, and the expensive cancellation path
(which includes signal blocking) is optimized out when there are no
active aio queues.
| Rich Felker | 2015-02-13 | 9 | -193/+440 |
| * | fix bad character checking in wordexp•••the character sequence '$((' was incorrectly interpreted as the
opening of arithmetic even within single-quoted contexts, thereby
suppressing the checks for bad characters after the closing quote.
presently bad character checking is only performed when the WRDE_NOCMD
is used; this patch only corrects checking in that case.
| Rich Felker | 2015-02-11 | 1 | -0/+1 |
| * | refactor passwd file access code•••this allows getpwnam and getpwuid to share code with the _r versions
in preparation for alternate backend support.
| Josiah Worcester | 2015-02-10 | 6 | -49/+65 |
| * | x86_64/memset: avoid performing final store twice•••The code does a potentially misaligned 8-byte store to fill the tail
of the buffer. Then it fills the initial part of the buffer
which is a multiple of 8 bytes.
Therefore, if size is divisible by 8, we were storing last word twice.
This patch decrements byte count before dividing it by 8,
making one less store in "size is divisible by 8" case,
and not changing anything in all other cases.
All at the cost of replacing one MOV insn with LEA insn.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| Denys Vlasenko | 2015-02-10 | 1 | -1/+1 |
| * | x86_64/memset: simple optimizations•••"and $0xff,%esi" is a six-byte insn (81 e6 ff 00 00 00), can use
4-byte "movzbl %sil,%esi" (40 0f b6 f6) instead.
64-bit imul is slow, move it as far up as possible so that the result
(rax) has more time to be ready by the time we start using it
in mem stores.
There is no need to shuffle registers in preparation to "rep movs"
if we are not going to take that code path. Thus, patch moves
"jump if len < 16" instructions up, and changes alternate code path
to use rdx and rdi instead of rcx and r8.
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
| Denys Vlasenko | 2015-02-10 | 1 | -14/+16 |
| * | make protocol table zero byte separated and add ipv6 protocols | Timo Teräs | 2015-02-10 | 1 | -22/+26 |
| * | use the internal macro name FUTEX_PRIVATE in __wait•••the name was recently added for the setxid/synccall rework,
so use the name now that we have it.
| Szabolcs Nagy | 2015-02-09 | 1 | -1/+1 |
| * | add IEEE binary128 long double support to floatscan•••just defining the necessary constants:
LD_B1B_MAX is 2^113 - 1 in base 10^9
KMAX is 2048 so the x array can hold up to 18432 decimal digits
(the worst case is converting 2^-16495 = 5^16495 * 10^-16495 to
binary, it requires the processing of int(log10(5)*16495)+1 = 11530
decimal digits after discarding the leading zeros, the conversion
requires some headroom in x, but KMAX is more than enough for that)
However this code is not optimal on archs with IEEE binary128
long double because the arithmetics is software emulated (on
all such platforms as far as i know) which means big and slow
strtod.
| Szabolcs Nagy | 2015-02-09 | 1 | -1/+9 |
| * | math: fix fmodl for IEEE binary128•••This trivial copy-paste bug went unnoticed due to lack of testing.
No currently supported target archs are affected.
| Szabolcs Nagy | 2015-02-09 | 1 | -1/+1 |
| * | simplify armhf fesetenv•••armhf fesetenv implementation did a useless read of the fpscr.
| Szabolcs Nagy | 2015-02-08 | 1 | -1/+0 |
| * | fix fesetenv(FE_DFL_ENV) on mips•••mips fesetenv did not handle FE_DFL_ENV, now fcsr is cleared in that
case.
| Szabolcs Nagy | 2015-02-08 | 1 | -1/+3 |
| * | math: fix __fpclassifyl(-0.0) for IEEE binary128•••The sign bit was not cleared before checking for 0 so -0.0
was misclassified as FP_SUBNORMAL instead of FP_ZERO.
| Szabolcs Nagy | 2015-02-08 | 1 | -3/+2 |
| * | add parenthesis in fma.c to clarify intent and silence warnings | Szabolcs Nagy | 2015-02-08 | 1 | -1/+1 |
| * | make getaddrinfo support SOCK_RAW and other socket types•••all socket types are accepted at this point, but that may be changed
at a later time if the behavior is not meaningful for other types. as
before, omitting type (a value of 0) gives both UDP and TCP results,
and SOCK_DGRAM or SOCK_STREAM restricts to UDP or TCP, respectively.
for other socket types, the service name argument is required to be a
null pointer, and the protocol number provided by the caller is used.
| Rich Felker | 2015-02-07 | 4 | -34/+42 |
| * | remove cruft from x86_64 syscall.h•••x86_64 syscall.h defined some musl internal syscall names and made
them public. These defines were already moved to src/internal/syscall.h
(except for SYS_fadvise which is added now) so the cruft in x86_64
syscall.h is not needed.
| Szabolcs Nagy | 2015-02-07 | 1 | -0/+3 |
| * | fix failure of fchmodat to report EOPNOTSUPP in the race path•••in the case where a non-symlink file was replaced by a symlink during
the fchmodat operation with AT_SYMLINK_NOFOLLOW, mode change on the
new symlink target was successfully suppressed, but the error was not
reported. instead, fchmodat simply returned 0.
| Rich Felker | 2015-02-05 | 1 | -2/+4 |
| * | fix fd leak race (missing O_CLOEXEC) in fchmodat | Rich Felker | 2015-02-04 | 1 | -1/+1 |
| * | make execvp continue PATH search on EACCES rather than issuing an errror•••the specification for execvp itself is unclear as to whether
encountering a file that cannot be executed due to EACCES during the
PATH search is a mandatory error condition; however, XBD 8.3's
specification of the PATH environment variable clarifies that the
search continues until a file with "appropriate execution permissions"
is found.
since it seems undesirable/erroneous to report ENOENT rather than
EACCES when an early path element has a non-executable file and all
later path elements lack any file by the requested name, the new code
stores a flag indicating that EACCES was seen and sets errno back to
EACCES in this case.
| Rich Felker | 2015-02-03 | 1 | -1/+4 |
| * | fix missing memory barrier in cancellation signal handler•••in practice this was probably a non-issue, because the necessary
barrier almost certainly exists in kernel space -- implementing signal
delivery without such a barrier seems impossible -- but for the sake
of correctness, it should be done here too.
in principle, without a barrier, it is possible that the thread to be
cancelled does not see the store of its cancellation flag performed by
another thread. this affects both the case where the signal arrives
before entering the critical program counter range from __cp_begin to
__cp_end (in which case both the signal handler and the inline check
fail to see the value which was already stored) and the case where the
signal arrives during the critical range (in which case the signal
handler should be responsible for cancellation, but when it does not
see the cancellation flag, it assumes the signal is spurious and
refuses to act on it).
in the fix, the barrier is placed only in the signal handler, not in
the inline check at the beginning of the critical program counter
range. if the signal handler runs before the critical range is
entered, it will of course take no action, but its barrier will ensure
that the inline check subsequently sees the store. if on the other
hand the inline check runs first, it may miss seeing the store, but
the subsequent signal handler in the critical range will act upon the
cancellation request. this strategy avoids adding a memory barrier in
the common, non-cancellation code path.
| Rich Felker | 2015-02-03 | 1 | -0/+1 |
| * | make fsync, fdatasync, and msync cancellation points•••these are mandatory cancellation points per POSIX, so their omission
was a conformance bug.
| Trutz Behn | 2015-01-30 | 3 | -3/+3 |
| * | fix missing comma in sh setjmp asm•••this typo did not result in an erroneous setjmp with at least binutils
2.22 but fix it for clarity and compatibility with potentially stricter
sh assemblers.
| Trutz Behn | 2015-01-30 | 1 | -1/+1 |
| * | fix erroneous return of partial username matches by getspnam[_r]•••when using /etc/shadow (rather than tcb) as its backend, getspnam_r
matched any username starting with the caller-provided string rather
than requiring an exact match. in practice this seems to have affected
only systems where one valid username is a prefix for another valid
username, and where the longer username appears first in the shadow
file.
| Rich Felker | 2015-01-21 | 1 | -1/+1 |
| * | simplify part of getopt_long•••as a result of commit e8e4e56a8ce1f3d7e4a027ff5478f2f8ea70c46b,
the later code path for setting optarg to a null pointer is no longer
necessary, and removing it eliminates an indention level and arguably
makes the code more readable.
| Rich Felker | 2015-01-21 | 1 | -13/+11 |
| * | always set optarg in getopt_long•••the standard getopt does not touch optarg unless processing an option
with an argument. however, programs using the GNU getopt API, which we
attempt to provide in getopt_long, expect optarg to be a null pointer
after processing an option without an argument.
before argument permutation support was added, such programs typically
detected its absence and used their own replacement getopt_long,
masking the discrepency in behavior.
| Rich Felker | 2015-01-21 | 1 | -1/+1 |
| * | overhaul __synccall and fix AS-safety and other issues in set*id•••multi-threaded set*id and setrlimit use the internal __synccall
function to work around the kernel's wrongful treatment of these
process properties as thread-local. the old implementation of
__synccall failed to be AS-safe, despite POSIX requiring setuid and
setgid to be AS-safe, and was not rigorous in assuring that all
threads were caught. in a worst case, threads late in the process of
exiting could retain permissions after setuid reported success, in
which case attacks to regain dropped permissions may have been
possible under the right conditions.
the new implementation of __synccall depends on the presence of
/proc/self/task and will fail if it can't be opened, but is able to
determine that it has caught all threads, and does not use any locks
except its own. it thereby achieves AS-safety simply by blocking
signals to preclude re-entry in the same thread.
with this commit, all known conformance and safety issues in set*id
functions should be fixed.
| Rich Felker | 2015-01-15 | 2 | -44/+137 |
| * | add FUTEX_PRIVATE macro to internal futex.h | Rich Felker | 2015-01-15 | 1 | -0/+2 |
| * | suppress EINTR in sem_wait and sem_timedwait•••per POSIX, the EINTR condition is an optional error for these
functions, not a mandatory one. since old kernels (pre-2.6.22) failed
to honor SA_RESTART for the futex syscall, it's dangerous to trust
EINTR from the kernel. thankfully POSIX offers an easy way out.
| Rich Felker | 2015-01-15 | 1 | -1/+1 |
| * | for multithreaded set*id/setrlimit, handle case where callback does not run•••in the current version of __synccall, the callback is always run, so
failure to handle this case did not matter. however, the upcoming
overhaul of __synccall will have failure cases, in which case the
callback does not run and errno is already set. the changes being
committed now are in preparation for that.
| Rich Felker | 2015-01-15 | 2 | -4/+4 |
| * | increase syslog message limit from 256 to 1024•••this addresses alpine linux issue #3692 and brings the syslog message
length limit in alignment with uclibc's implementation.
| Rich Felker | 2015-01-13 | 1 | -1/+1 |
| * | remove rlimit hacks from multi-threaded set*id() code•••the code being removed was introduced to work around "partial failure"
of multi-threaded set*id() operations, where some threads would
succeed in changing their ids but an RLIMIT_NPROC setting would
prevent the rest from succeeding, leaving the process in an
inconsistent and dangerous state. however, the workaround code did not
handle important usage cases like swapping real and effective uids
then restoring their original values, and the wrongful kernel
enforcement of RLIMIT_NPROC at setuid time was removed in Linux 3.1,
making the workaround obsolete.
since the partial failure still is dangerous on old kernels, and could
in principle happen on post-fix kernels as well if set*id() syscalls
fail for another spurious reason such as resource-related failures,
new code is added to detect and forcibly kill the process if/when such
a situation arises. future documentation releases should be updated to
reflect that setting RLIMIT_NPROC to RLIM_INFINITY is necessary to
avoid this forced-kill on old kernels. ideally, at some point the
kernel will get proper multi-threaded set*id() syscalls capable of
performing their actions atomically, and all of the userspace code to
emulate them can be treated as a fallback for outdated kernels.
| Rich Felker | 2015-01-12 | 1 | -23/+15 |
| * | simplify ctermid•••opening /dev/tty then using ttyname_r on it does not produce a
canonical terminal name; it simply yields "/dev/tty".
it would be possible to make ctermid determine the actual controlling
terminal device via field 7 of /proc/self/stat, but doing so would
introduce a buffer overflow into applications built with L_ctermid==9,
which glibc defines, adversely affecting the quality of ABI compat.
| Rich Felker | 2015-01-12 | 1 | -14/+2 |
| * | fix regression in getopt_long support for non-option arguments•••commit b72cd07f176b876aa51864d93aa8101477b1d732 added support for a
this feature in getopt, but it was later broken in the case where
getopt_long is used as a side effect of the changes made in commit
91184c4f16b143107fa9935edebe5d2b20bd70d8, which prevented the
underlying getopt call from seeing the leading '-' or '+' character in
optstring.
this commit changes the logic in the getopt_long core to check for a
leading colon, possibly after the leading '-' or '+', without
depending on the latter having been skipped by the caller. a minor
incorrectness in the return value for one error condition in
getopt_long is also fixed when opterr has been set to zero but
optstring has no leading ':'.
| Rich Felker | 2015-01-11 | 1 | -7/+6 |
| * | check for connect failure in syslog log opening•••based on patch by Dima Krasner, with minor improvements for code size.
connect can fail if there is no listening syslogd, in which case a
useless socket was kept open, preventing subsequent syslog call from
attempting to connect again.
| Rich Felker | 2015-01-09 | 1 | -2/+6 |
| * | overhaul forkpty function using new login_tty•••based on discussion with and patches by Felix Janda. these changes
started as an effort to factor forkpty in terms of login_tty, which
returns an error and skips fd reassignment and closing if setting the
controlling terminal failed. the previous forkpty code was unable to
handle errors in the child, and did not attempt to; it just silently
ignored them. but this would have been unacceptable when switching to
using login_tty, since the child would start with the wrong stdin,
stdout, and stderr and thereby clobber the parent's files.
the new code uses the same technique as the posix_spawn implementation
to convey any possible error in the child to the parent so that the
parent can report failure to the caller. it is also safe against
thread cancellation and against signal delivery in the child prior to
the determination of success.
| Rich Felker | 2014-12-21 | 1 | -24/+43 |
