| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | move declarations of tls setup/access functions to pthread_impl.h•••it's already included in all places where these are needed, and aside
from __tls_get_addr, they're all implementation internals.
| Rich Felker | 2018-09-12 | 4 | -6/+6 |
| * | add and use internal header for *rand48 lcg | Rich Felker | 2018-09-12 | 8 | -13/+12 |
| * | move __strftime_fmt_1 declaration to time_impl.h•••this is a helper function from strftime that's also used by wcsftime.
| Rich Felker | 2018-09-12 | 2 | -2/+2 |
| * | move __tm_to_tzname declaration to time_impl.h with related functions•••this function was added later for strftime use and the existence of
time_impl.h as the appropriate place for it seems to have been
overlooked.
| Rich Felker | 2018-09-12 | 2 | -1/+1 |
| * | remove unused code from strcpy.c | Rich Felker | 2018-09-12 | 1 | -7/+0 |
| * | move __res_msend_rc declaration to lookup.h•••unlike the other res/dn functions, this one is tied to struct
resolvconf which is not a public interface, so put it in the private
header for its subsystem.
| Rich Felker | 2018-09-12 | 2 | -1/+1 |
| * | fix type-mismatched declarations of __nl_langinfo_l in source files•••obviously the type "should be" const, but it inherited non-const from
the standard nl_langinfo_l.
| Rich Felker | 2018-09-12 | 2 | -2/+2 |
| * | for c11 mtx and cnd functions, use externally consistent type names•••despite looking like undefined behavior, the affected code is correct
both before and after this patch. the pairs mtx_t and pthread_mutex_t,
and cnd_t and pthread_cond_t, are not mutually compatible within a
single translation unit (because they are distinct untagged aggregate
instances), but they are compatible with an object of either type from
another translation unit (6.2.7 ΒΆ1), and therefore a given translation
unit can choose which one it wants to use.
in the interest of being able to move declarations out of source files
to headers that facilitate checking, use the pthread type names in
declaring the namespace-safe versions of the pthread functions and
cast the argument pointer types when calling them.
| Rich Felker | 2018-09-12 | 6 | -12/+17 |
| * | move and deduplicate declarations of __dns_parse to make it checkable•••the source file for this function is completely standalone, but it
doesn't seem worth adding a header just for it, so declare it in
lookup.h for now.
| Rich Felker | 2018-09-12 | 4 | -2/+3 |
| * | move lgamma-related internal declarations to libm.h | Rich Felker | 2018-09-12 | 5 | -12/+7 |
| * | declare __syscall_ret as hidden in vfork asm•••without this, it's plausible that assembler or linker could complain
about an unsatisfiable relocation.
| Rich Felker | 2018-09-12 | 4 | -0/+4 |
| * | add arm asm for vfork | Patrick Oppenlander | 2018-09-12 | 1 | -0/+13 |
| * | move declarations for malloc internals to malloc_impl.h | Rich Felker | 2018-09-12 | 4 | -6/+6 |
| * | improve machinery for ldso to report libc version•••eliminate gratuitous glue function for reporting the version, which
was probably leftover from the old dynamic linker design which lacked
a clear barrier for when/how it could access global data. put the
declaration for the data object that replaces it in libc.h where it
can be type checked.
| Rich Felker | 2018-09-12 | 2 | -6/+3 |
| * | make internal declarations for flockfile tracking functions checkable•••logically these belong to the intersection of the stdio and pthread
subsystems, and either place the declarations could go (stdio_impl.h
or pthread_impl.h) requires a forward declaration for one of the
argument types.
| Rich Felker | 2018-09-12 | 3 | -4/+5 |
| * | make inadvertently exposed __h{create,delete,search}_r functions static | Rich Felker | 2018-09-12 | 1 | -6/+6 |
| * | make inadvertently exposed __pthread_{timed,try}join_np functions static•••these exist for the sake of defining the corresponding weak public
aliases (for C11 and POSIX namespace conformance reasons). they are
not referenced by anything else in libc, so make them static.
| Rich Felker | 2018-09-12 | 1 | -2/+2 |
| * | use idiomatic weak alias approach for defining asctime_r•••get rid of a gratuitous translation unit and call frame between
asctime_r and the actual implementation of the function. this is the
way gmtime_r and localtime_r are already done.
| Rich Felker | 2018-09-12 | 3 | -33/+28 |
| * | move and deduplicate declarations of __vdsosym to make it checkable | Rich Felker | 2018-09-12 | 3 | -4/+2 |
| * | move and deduplicate declarations of __procfdname to make it checkable•••syscall.h was chosen as the header to declare it, since its intended
usage is alongside syscalls as a fallback for operations the direct
syscall does not support.
| Rich Felker | 2018-09-12 | 10 | -16/+5 |
| * | fix issues from public functions defined without declaration visible•••policy is that all public functions which have a public declaration
should be defined in a context where that public declaration is
visible, to avoid preventable type mismatches.
an audit performed using GCC's -Wmissing-declarations turned up the
violations corrected here. in some cases the public header had not
been included; in others, a feature test macro needed to make the
declaration visible had been omitted.
in the case of gethostent and getnetent, the omission seems to have
been intentional, as a hack to admit a single stub definition for both
functions. this kind of hack is no longer acceptable; it's UB and
would not fly with LTO or advanced toolchains. the hack is undone to
make exposure of the declarations possible.
| Rich Felker | 2018-09-12 | 11 | -2/+22 |
| * | remove leftover declarations for removed functions from pthread_impl.h | Rich Felker | 2018-09-05 | 1 | -4/+0 |
| * | define and use internal macros for hidden visibility, weak refs•••this cleans up what had become widespread direct inline use of "GNU C"
style attributes directly in the source, and lowers the barrier to
increased use of hidden visibility, which will be useful to recovering
some of the efficiency lost when the protected visibility hack was
dropped in commit dc2f368e565c37728b0d620380b849c3a1ddd78f, especially
on archs where the PLT ABI is costly.
| Rich Felker | 2018-09-05 | 29 | -88/+66 |
| * | fix namespace violation for c11 mutex functions•••__pthread_mutex_timedlock is used to implement c11 mutex functions,
and therefore cannot call pthread_mutex_trylock by name.
| Rich Felker | 2018-09-04 | 1 | -1/+3 |
| * | in pthread_mutex_timedlock, avoid repeatedly reading mutex type field•••compiler cannot cache immutable fields of the mutex object across
external calls it can't see, much less across atomics.
| Rich Felker | 2018-09-04 | 1 | -3/+4 |
| * | in pthread_mutex_trylock, EBUSY out more directly when possible•••avoid gratuitously setting up and tearing down the robust list pending
slot.
| Rich Felker | 2018-09-04 | 1 | -2/+2 |
| * | implement fexecve in terms of execveat when it exists•••This lets fexecve work even when /proc isn't mounted.
| Joseph C. Sible | 2018-09-04 | 1 | -0/+5 |
| * | fix stack-based oob memory clobber in resolver's result sorting•••commit 4f35eb7591031a1e5ef9828f9304361f282f28b9 introduced this bug.
it is not present in any released versions. inadvertent use of the &
operator on an array into which we're indexing produced arithmetic on
the wrong-type pointer, with undefined behavior.
| Rich Felker | 2018-09-02 | 1 | -1/+1 |
| * | consistently use _NSIG/8 idiom for kernel sigset size in sigaction•••this code in sigaction was the only place where sizeof was being
applied to the kernel sigaction's mask member to get the size argument
to pass to the kernel. everywhere else, _NSIG/8 is used for this
purpose.
| Rich Felker | 2018-09-01 | 1 | -3/+3 |
| * | always terminate by SIGABRT when abort is called•••Linux makes this surprisingly difficult, but it can be done. the trick
here is using the fact that we control the implementation of sigaction
to prevent changing the disposition of SIGABRT to anything but SIG_DFL
after abort has tried and failed to terminate the process simply by
calling raise(SIGABRT).
| Rich Felker | 2018-09-01 | 2 | -4/+40 |
| * | optimize raise not to make a syscall for getting tid•••assuming signals are blocked, which they are here, the tid in the
thread structure is always valid and cannot change out from under us.
| Rich Felker | 2018-09-01 | 1 | -3/+1 |
| * | prevent perror from clobbering stderr's orientation•••this requirement is specified by POSIX.
| Rich Felker | 2018-08-30 | 1 | -0/+8 |
| * | prevent psignal/psiginfo from clobbering stderr orientation, errno•••these functions are specified to write to stderr but not set its
orientation, presumably so that they can be used in programs operating
stderr in wide mode. also, they are not allowed to clobber errno on
success. save and restore to meet the requirement.
psiginfo is reduced to a think wrapper around psignal, since it
already behaved the same. if we want to add more detailed siginfo
printing at some point this will need refactoring.
| Rich Felker | 2018-08-30 | 2 | -8/+21 |
| * | make vfprintf set stream orientation even for zero-length output•••if no output is produced, no underlying fwrite will ever be called,
but byte-oriented printf functions are still required to set the
orientation of the stream to byte-oriented. call __towrite explicitly
if the FILE is not already in write mode.
| Rich Felker | 2018-08-29 | 1 | -1/+2 |
| * | re-fix vfprintf temporary buffer logic•••commit b5a8b28915aad17b6f49ccacd6d3fef3890844d1 setup the write buffer
bound pointers for the temporary buffer manually to fix a buffer
overflow issue, but in doing so, caused vfprintf on unbuffered files
never to call __towrite, thereby failing to set the stream orientation
to byte-oriented, failing to clear any prior read mode, and failing to
produce an error when the stream is not writable.
revert the inline setup of the bounds pointers and instead zero them,
so that the underlying fwrite code will call __towrite to set them up.
| Rich Felker | 2018-08-29 | 1 | -2/+2 |
| * | fix missing flush of stderr at exit if it was put in buffered mode•••commit 0b80a7b0404b6e49b0b724e3e3fe0ed5af3b08ef added the ability to
set application-provided stdio FILE buffers, adding the possibility
that stderr might be buffered at exit time, but __stdio_exit did not
have code to flush it.
this regression was not present in any release.
| Rich Felker | 2018-08-29 | 1 | -0/+1 |
| * | fix async thread cancellation on sh-fdpic•••if __cp_cancel was reached via __syscall_cp, r12 will necessarily
still contain a GOT pointer (for libc.so or for the static-linked main
program) valid for entering __cancel. however, in the case of async
cancellation, r12 may contain any scratch value; it's not necessarily
even a valid GOT pointer for the code that was interrupted.
unlike in commit 0ec49dab6794166d67fae4764ce7fdea42ea6103 where the
corresponding issue was fixed for powerpc64, there is fundamentally no
way for fdpic code to recompute its GOT pointer. so a new mechanism is
introduced for cancel_handler to write a GOT register value into the
interrupted context on archs where it is needed.
| Rich Felker | 2018-08-29 | 1 | -0/+3 |
| * | fix async thread cancellation on powerpc64•••entering the local entry point for __cancel from __cp_cancel is valid
if __cp_cancel was reached from __syscall_cp, since both are in libc
and share the same TOC pointer, but it is not valid if __cp_cancel was
reached when cancel_handler rewrote the program counter for
asynchronous cancellation of code outside libc.
to ensure __cancel is entered with a valid TOC pointer, recompute the
correct value in a PC-relative manner before jumping.
| Rich Felker | 2018-08-29 | 1 | -0/+7 |
| * | vfwprintf: honor field width with 'c' format type | A. Wilcox | 2018-08-28 | 1 | -1/+4 |
| * | fix several values reported by sysconf•••- REALTIME_SIGNALS is supposed to be version-valued
- DELAYTIMER_MAX was wrongly using the min allowed max
- unavailable compilation environments wrongly used 0 instead of -1
| Rich Felker | 2018-08-28 | 1 | -8/+11 |
| * | fix return value of system on failure to spawn child process•••the value 0x7f00 (as if by _exit(127)) is specified only for the case
where the child is created but then fails to exec the shell, since
traditional fork+exec implementations do not admit reporting an error
via errno in this case without additional machinery. it's unclear
whether an implementation not subject to this failure mode needs to
emulate it; one could read the standard as requiring that. if so,
additional code will need to be added to map posix_spawn errors into
the form system is expected to return. but for now, returning -1 to
indicate an error is significantly better behavior than always
reporting failures as if the shell failed to exec after fork.
| Rich Felker | 2018-08-28 | 1 | -1/+1 |
| * | set stream orientations in open_[w]memstream•••fundamentally there is no good reason these functions need to set an
orientation (morally it should be possible to write a wchar_t[] memory
stream using byte functions, or a char[] memory stream using wide
functions), but it's a part of the specification that they do. aside
from being able to inspect the orientation with fwide, failure to set
the orientation in open_wmemstream is observable if the locale changes
between open_wmemstream and the first operation on the stream; this is
because the encoding rule (locale) for the stream is required to be
bound at the time the stream becomes wide-oriented.
for open_wmemstream, call fwide to avoid duplicating the logic for
binding the encoding rule. for open_memstream it suffices just to set
the mode field in the FILE struct.
| Rich Felker | 2018-08-28 | 2 | -0/+3 |
| * | make fmemopen's w+ mode truncate the buffer•••the w+ mode is specified to "truncate the buffer contents". like most
of fmemopen, exactly what this means is underspecified. mode w and w+
of course implicitly 'truncate' the buffer if a write from the initial
position is flushed, so in order for this part of the text about w+
not to be spurious, it should be interpreted as requiring something
else, and the obvious reasonable interpretation is that the truncation
is immediately visible if you attempt to read from the stream or the
buffer before writing/flushing.
this interpretation agrees with reported conformance test failures.
| Rich Felker | 2018-08-28 | 1 | -0/+1 |
| * | set errno when fileno is called on a FILE with no underlying fd•••this is a POSIX requirement.
also remove the gratuitous locking shenanigans and simply access f->fd
under control of the lock. there is no advantage to not doing so, and
it made the correctness non-obvious at best.
| Rich Felker | 2018-08-28 | 1 | -4/+7 |
| * | reject invalid arguments to pthread_barrierattr_setpshared•••this is a POSIX requirement.
| Rich Felker | 2018-08-28 | 1 | -0/+1 |
| * | rewrite __aeabi_read_tp in asm•••__aeabi_read_tp used to call c code, but that was incorrect as the
arm runtime abi specifies special pcs for this function: it is only
allowed to clobber r0, ip, lr and cpsr.
maintainer's note: the old code explicitly saved and restored all
general-purpose registers which are call-clobbered in the normal
calling convention, so it's unlikely that any real-world compilers
produced code that could break. however theoretically they could have
chosen to use floating point registers, in which case the caller's
values of those registers would be clobbered.
| Szabolcs Nagy | 2018-08-28 | 2 | -12/+6 |
| * | fix deadlock in async thread self-cancellation•••with async cancellation enabled, pthread_cancel(pthread_self())
deadlocked due to pthread_kill holding killlock which is needed by
pthread_exit.
this could be solved by making pthread_kill block signals around the
critical section, at least when the target thread is itself, but the
issue only arises for cancellation, and otherwise would just be
imposing unnecessary cost.
instead just have pthread_cancel explicitly check for async
self-cancellation and call pthread_exit(PTHREAD_CANCELED) directly
rather than going through the signal machinery.
| Rich Felker | 2018-08-28 | 1 | -1/+5 |
| * | time: fix incorrect DST offset when using POSIX timezones without DST•••This manifests itself in mktime if tm_isdst = 1 and the current TZ= is
a POSIX timezone specification. mktime would see that tm_isdst was set
to 0 by __secs_to_zone, and subtract 'oppoff' (dst_off) - gmtoff from
the resultant time. This meant that mktime returned a time that was
exactly double the GMT offset of the desired timezone when tm_isdst
was = 1.
| A. Wilcox | 2018-08-27 | 1 | -1/+1 |
| * | fix tls access on arm targets before armv6k•••commit 610c5a8524c3d6cd3ac5a5f1231422e7648a3791 changed the thread
pointer setup so tp points at the end of the pthread struct on arm,
but failed to update __aeabi_read_tp so it was off by 8.
this broke tls access in code that is compiled with -mtp=soft, which
is the default when target arch is pre armv6k or thumb1.
maintainer's note: no release versions are affected.
| Szabolcs Nagy | 2018-08-23 | 1 | -1/+1 |
| * | fix missing strerror text for EMULTIHOP•••this is an obsolete error code from RFS, an obsolete predecessor of
NFS. POSIX documents it only as "Reserved", but maintains the
requirement that it be defined. as long as it is defined, it needs a
string for strerror to produce; the one chosen matches glibc and
documentation from other language runtimes I could find.
| Rich Felker | 2018-08-23 | 1 | -0/+1 |
