| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | remove errno setting from setenv, malloc sets it correctly on oom | Szabolcs Nagy | 2013-10-07 | 1 | -1/+0 |
| * | fix allocation sizes in regcomp•••sizeof had incorrect argument in a few places, the size was always
large enough so the issue was not critical.
| Szabolcs Nagy | 2013-10-07 | 1 | -4/+4 |
| * | add missing va_end in execl* for correcness and static code analyzers | Szabolcs Nagy | 2013-10-07 | 3 | -0/+3 |
| * | minor vfprintf and vfwprintf changes to please static code analyzers•••add missing va_end and remove some unnecessary code.
| Szabolcs Nagy | 2013-10-07 | 2 | -6/+11 |
| * | math: remove an unused variable from modfl | Szabolcs Nagy | 2013-10-06 | 1 | -1/+0 |
| * | slightly optimize __brk for size•••there is no reason to check the return value for setting errno, since
brk never returns errors, only the new value of the brk (which may be
the same as the old, or otherwise differ from the requested brk, on
failure).
it may be beneficial to eventually just eliminate this file and make
the syscalls inline in malloc.c.
| Rich Felker | 2013-10-05 | 1 | -1/+1 |
| * | fix failure of malloc to set errno on heap (brk) exhaustion•••I wrongly assumed the brk syscall would set errno, but on failure it
returns the old value of the brk rather than an error code.
| Rich Felker | 2013-10-05 | 1 | -0/+1 |
| * | fix failure to check malloc result in setenv | Rich Felker | 2013-10-04 | 1 | -9/+9 |
| * | math: remove code duplication in erfl found by clang analyzer•••erfl had some superflous code left around after the last erf cleanup.
the issue was reported by Alexander Monakov
| Szabolcs Nagy | 2013-10-04 | 1 | -13/+2 |
| * | math: remove a useless assignment in lgammal found by clang analyzer•••the issue was reported by Alexander Monakov
| Szabolcs Nagy | 2013-10-04 | 1 | -2/+2 |
| * | fix invalid implicit pointer conversion in pthread_key_create | Rich Felker | 2013-10-04 | 1 | -1/+1 |
| * | fix uninitialized variable in dladdr•••the affected branch only applies for DSOs that lack standard hash
table and only have the GNU hash table present.
| Rich Felker | 2013-10-04 | 1 | -1/+1 |
| * | removed unused variable in vfwprintf | Rich Felker | 2013-10-04 | 1 | -2/+1 |
| * | fix new environment always being null with execle•••the va_arg call for the argv[]-terminating null pointer was missing,
so this pointer was being wrongly used as the environment pointer.
issue reported by Timo Teräs. proposed patch slightly modified to
simplify the resulting code.
| Rich Felker | 2013-10-03 | 1 | -2/+1 |
| * | fix off-by-one error in getgrnam_r and getgrgid_r, clobbering gr_name•••bug report and patch by Michael Forney. the terminating null pointer
at the end of the gr_mem array was overwriting the beginning of the
string data, causing the gr_name member to always be a zero-length
string.
| Rich Felker | 2013-09-29 | 1 | -2/+2 |
| * | fix buffer overflow in mbsrtowcs•••issue reported by Michael Forney:
"If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently
continues on, wrapping wn around to -1, causing the rest of the string
to be processed.
This resulted in buffer overruns if there was only space in ws for wn
wide characters."
the original patch submitted added an additional check for !wn after
the loop; to avoid extra branching, I instead just changed the wn>=4
check to wn>=5 to ensure that at least one slot remains after the
word-at-a-time loop runs. this should not slow down the tail
processing on real-world usage, since an extra slot that can't be
processed in the word-at-a-time loop is needed for the null
termination anyway.
| Rich Felker | 2013-09-27 | 1 | -1/+1 |
| * | fix potential deadlock bug in libc-internal locking logic•••if a multithreaded program became non-multithreaded (i.e. all other
threads exited) while one thread held an internal lock, the remaining
thread would fail to release the lock. the the program then became
multithreaded again at a later time, any further attempts to obtain
the lock would deadlock permanently.
the underlying cause is that the value of libc.threads_minus_1 at
unlock time might not match the value at lock time. one solution would
be returning a flag to the caller indicating whether the lock was
taken and needs to be unlocked, but there is a simpler solution: using
the lock itself as such a flag.
note that this flag is not needed anyway for correctness; if the lock
is not held, the unlock code is harmless. however, the memory
synchronization properties associated with a_store are costly on some
archs, so it's best to avoid executing the unlock code when it is
unnecessary.
| Rich Felker | 2013-09-20 | 3 | -13/+15 |
| * | correct the sysconf value for RTSIG_MAX•••this is the number of realtime signals available, not the maximum
signal number or total number of signals.
| Rich Felker | 2013-09-20 | 1 | -1/+2 |
| * | fix sigemptyset and sigfillset for mips•••they were leaving junk in the upper bits.
| Rich Felker | 2013-09-16 | 2 | -1/+10 |
| * | fix clobbering of caller's stack in mips __clone function•••this was resulting in crashes in posix_spawn on mips, and would have
affected applications calling clone too. since the prototype for
__clone has it as a variadic function, it may not assume that 16($sp)
is writable for use in making the syscall. instead, it needs to
allocate additional stack space, and then adjust the stack pointer
back in both of the code paths for the parent process/thread.
| Rich Felker | 2013-09-16 | 1 | -0/+3 |
| * | omit CLONE_PARENT flag to clone in pthread_create•••CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful
parts of it) and Linux treats CLONE_PARENT as an error in certain
situations, without noticing that it would be a no-op due to
CLONE_THREAD. this error case prevents, for example, use of a
multi-threaded init process and certain usages with containers.
| Rich Felker | 2013-09-16 | 1 | -1/+1 |
| * | use symbolic names for clone flags in pthread_create | Rich Felker | 2013-09-16 | 1 | -2/+5 |
| * | support configurable page size on mips, powerpc and microblaze•••PAGE_SIZE was hardcoded to 4096, which is historically what most
systems use, but on several archs it is a kernel config parameter,
user space can only know it at execution time from the aux vector.
PAGE_SIZE and PAGESIZE are not defined on archs where page size is
a runtime parameter, applications should use sysconf(_SC_PAGE_SIZE)
to query it. Internally libc code defines PAGE_SIZE to libc.page_size,
which is set to aux[AT_PAGESZ] in __init_libc and early in __dynlink
as well. (Note that libc.page_size can be accessed without GOT, ie.
before relocations are done)
Some fpathconf settings are hardcoded to 4096, these should be actually
queried from the filesystem using statfs.
| Szabolcs Nagy | 2013-09-15 | 12 | -11/+24 |
| * | fix overflow in sysconf for _SC_MQ_PRIO_MAX•••the value of MQ_PRIO_MAX does not fit, so it needs to use OFLOW.
| Rich Felker | 2013-09-14 | 1 | -1/+2 |
| * | fix child stack alignment on mips clone•••unlike other archs, the mips version of clone was not doing anything
to align the stack pointer. this seems to have been the cause for some
SIGBUS crashes that were observed in posix_spawn.
| Rich Felker | 2013-09-14 | 1 | -0/+1 |
| * | fix x86_64 lrintl asm, again•••the underlying problem was not incorrect sign extension (fixed in the
previous commit to this file by nsz) but that code that treats "long"
as 32-bit was copied blindly from i386 to x86_64.
now lrintl is identical to llrintl on x86_64, as it should be.
| Rich Felker | 2013-09-13 | 1 | -2/+2 |
| * | do not use default when dynamic linker fails to open existing path file•••if fopen fails for a reason other than ENOENT, we must assume the
intent is that the path file be used. failure may be due to
misconfiguration or intentional resource-exhaustion attack (against
suid programs), in which case falling back to loading libraries from
an unintended path could be dangerous.
| Rich Felker | 2013-09-09 | 1 | -0/+2 |
| * | math: remove STRICT_ASSIGN from exp2f (see previous commit) | Szabolcs Nagy | 2013-09-06 | 1 | -1/+1 |
| * | math: remove STRICT_ASSIGN macro•••gcc did not always drop excess precision according to c99 at assignments
before version 4.5 even if -std=c99 was requested which caused badly
broken mathematical functions on i386 when FLT_EVAL_METHOD!=0
but STRICT_ASSIGN was not used consistently and it is worked around for
old compilers with -ffloat-store so it is no longer needed
the new convention is to get the compiler respect c99 semantics and when
excess precision is not harmful use float_t or double_t or to specialize
code using FLT_EVAL_METHOD
| Szabolcs Nagy | 2013-09-06 | 11 | -23/+13 |
| * | math: support invalid ld80 representations in fpclassify•••apparently gnulib requires invalid long double representations
to be handled correctly in printf so we classify them according
to how the fpu treats them: bad inf is nan, bad nan is nan,
bad normal is nan and bad subnormal/zero is minimal normal
| Szabolcs Nagy | 2013-09-05 | 1 | -2/+4 |
| * | math: fix atanh (overflow and underflow issues)•••in atanh exception handling was left to the called log functions,
but the argument to those functions could underflow or overflow.
use double_t and float_t to avoid some useless stores on x86
| Szabolcs Nagy | 2013-09-05 | 3 | -14/+37 |
| * | math: remove libc.h include from libm.h•••libc.h is only for weak_alias so include it directly where it is used
| Szabolcs Nagy | 2013-09-05 | 5 | -3/+5 |
| * | math: fix acoshf on negative values•••acosh(x) is invalid for x<1, acoshf tried to be clever using
signed comparisions to handle all x<2 the same way, but the
formula was wrong on large negative values.
| Szabolcs Nagy | 2013-09-05 | 2 | -7/+8 |
| * | math: fix expm1l on x86_64 (avoid underflow for large negative x)•••copy the fix from i386: return -1 instead of exp2l(x)-1 when x <= -65
| Szabolcs Nagy | 2013-09-05 | 3 | -3/+13 |
| * | math: fix lrintl.s on x86_64 (use movslq to signextend the result) | Szabolcs Nagy | 2013-09-05 | 1 | -1/+1 |
| * | math: fix exp2l asm on x86 (raise underflow correctly)•••there were two problems:
* omitted underflow on subnormal results: exp2l(-16383.5) was calculated
as sqrt(2)*2^-16384, the last bits of sqrt(2) are zero so the down scaling
does not underflow eventhough the result is in subnormal range
* spurious underflow for subnormal inputs: exp2l(0x1p-16400) was evaluated
as f2xm1(x)+1 and f2xm1 raised underflow (because inexact subnormal result)
the first issue is fixed by raising underflow manually if x is in
(-32768,-16382] and not integer (x-0x1p63+0x1p63 != x)
the second issue is fixed by treating x in (-0x1p64,0x1p64) specially
for these fixes the special case handling was completely rewritten
| Szabolcs Nagy | 2013-09-05 | 2 | -67/+78 |
| * | math: cosmetic cleanup (use explicit union instead of fshape and dshape) | Szabolcs Nagy | 2013-09-05 | 11 | -166/+140 |
| * | math: remove *_WORD64 macros from libm.h•••only fma used these macros and the explicit union is clearer
| Szabolcs Nagy | 2013-09-05 | 2 | -29/+13 |
| * | math: remove old longdbl.h | Szabolcs Nagy | 2013-09-05 | 2 | -113/+0 |
| * | math: long double fix (use ldshape union)•••* use new ldshape union consistently
* add ld128 support to frexpl
* simplify sqrtl comment (ld64 is not just arm)
| Szabolcs Nagy | 2013-09-05 | 8 | -51/+24 |
| * | math: use float_t and double_t in scalbnf and scalbn•••remove STRICT_ASSIGN (c99 semantics is assumed) and use the conventional
union to prepare the scaling factor (so libm.h is no longer needed)
| Szabolcs Nagy | 2013-09-05 | 2 | -16/+20 |
| * | math: fix remaining old long double code (erfl, fmal, lgammal, scalbnl)•••in lgammal don't handle 1 and 2 specially, in fma use the new ldshape
union instead of ld80 one.
| Szabolcs Nagy | 2013-09-05 | 5 | -93/+65 |
| * | math: cbrt cleanup and long double fix•••* use float_t and double_t
* cleanup subnormal handling
* bithacks according to the new convention (ldshape for long double
and explicit unions for float and double)
| Szabolcs Nagy | 2013-09-05 | 3 | -72/+59 |
| * | math: fix underflow in exp*.c and long double handling in exp2l•••* don't care about inexact flag
* use double_t and float_t (faster, smaller, more precise on x86)
* exp: underflow when result is zero or subnormal and not -inf
* exp2: underflow when result is zero or subnormal and not exact
* expm1: underflow when result is zero or subnormal
* expl: don't underflow on -inf
* exp2: fix incorrect comment
* expm1: simplify special case handling and overflow properly
* expm1: cleanup final scaling and fix negative left shift ub (twopk)
| Szabolcs Nagy | 2013-09-05 | 8 | -182/+139 |
| * | math: long double trigonometric cleanup (cosl, sinl, sincosl, tanl)•••ld128 support was added to internal kernel functions (__cosl, __sinl,
__tanl, __rem_pio2l) from freebsd (not tested, but should be a good
start for when ld128 arch arrives)
__rem_pio2l had some code cleanup, the freebsd ld128 code seems to
gather the results of a large reduction with precision loss (fixed
the bug but a todo comment was added for later investigation)
the old copyright was removed from the non-kernel wrapper functions
(cosl, sinl, sincosl, tanl) since these are trivial and the interesting
parts and comments had been already rewritten.
| Szabolcs Nagy | 2013-09-05 | 8 | -236/+228 |
| * | math: long double inverse trigonometric cleanup (acosl, asinl, atanl, atan2l)•••* added ld128 support from freebsd fdlibm (untested)
* using new ldshape union instead of IEEEl2bits
* inexact status flag is not supported
| Szabolcs Nagy | 2013-09-05 | 6 | -103/+180 |
| * | math: rewrite hypot•••method: if there is a large difference between the scale of x and y
then the larger magnitude dominates, otherwise reduce x,y so the
argument of sqrt (x*x+y*y) does not overflow or underflow and calculate
the argument precisely using exact multiplication. If the argument
has less error than 1/sqrt(2) ~ 0.7 ulp, then the result has less error
than 1 ulp in nearest rounding mode.
the original fdlibm method was the same, except it used bit hacks
instead of dekker-veltkamp algorithm, which is problematic for long
double where different representations are supported. (the new hypot
and hypotl code should be smaller and faster on 32bit cpu archs with
fast fpu), the new code behaves differently in non-nearest rounding,
but the error should be still less than 2ulps.
ld80 and ld128 are supported
| Szabolcs Nagy | 2013-09-05 | 3 | -324/+135 |
| * | math: rewrite remainder functions (remainder, remquo, fmod, modf)•••* results are exact
* modfl follows truncl (raises inexact flag spuriously now)
* modf and modff only had cosmetic cleanup
* remainder is just a wrapper around remquo now
* using iterative shift+subtract for remquo and fmod
* ld80 and ld128 are supported as well
| Szabolcs Nagy | 2013-09-05 | 11 | -1008/+470 |
| * | math: rewrite rounding functions (ceil, floor, trunc, round, rint)•••* faster, smaller, cleaner implementation than the bit hacks of fdlibm
* use arithmetics like y=(double)(x+0x1p52)-0x1p52, which is an integer
neighbor of x in all rounding modes (0<=x<0x1p52) and only use bithacks
when that's faster and smaller (for float it usually is)
* the code assumes standard excess precision handling for casts
* long double code supports both ld80 and ld128
* nearbyint is not changed (it is a wrapper around rint)
| Szabolcs Nagy | 2013-09-05 | 15 | -904/+273 |
| * | math: fix logb(-0.0) in downward rounding mode•••use -1/(x*x) instead of -1/(x+0) to return -inf, -0+0 is -0 in
downward rounding mode
| Szabolcs Nagy | 2013-09-05 | 3 | -6/+6 |
