| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | implement semtimedop•••this is a Linux-specific extension to the sysv semaphore api.
| Rich Felker | 2013-11-09 | 2 | -0/+14 |
| * | remove O_NOFOLLOW from __map_file used for time zone file loading•••it's not clear why I originally wrote O_NOFOLLOW into this; I suspect
the reason was with an aim of making the function more general for
mapping partially or fully untrusted files provided by the user.
however, the timezone code already precludes use of absolute or
relative pathnames in suid/sgid programs, and disallows .. in
pathnames which are relative to one of the system timezone locations,
so there is no threat of opening a symlink which is not trusted by
appropriate user. since some users may wish to put symbolic links in
the zoneinfo directories to alias timezones, it seems preferable to
allow this.
| Rich Felker | 2013-11-08 | 1 | -1/+1 |
| * | fix handling of overly-long TZ environment variable values•••the rest of the code is not prepared to handle an empty TZ string, so
falling back to __gmt ("GMT"), just as if TZ had been blank or unset,
is the preferable action.
| Rich Felker | 2013-11-08 | 1 | -1/+1 |
| * | timezone parser: fix iteration over search dir paths•••try+l points to \0, so only one iteration was ever tried.
| rofl0r | 2013-11-04 | 1 | -1/+1 |
| * | timezone parser: fix offset to transition table in 64bit code path•••we need to skip to the second TZif header, which starts at
skip+44, and then skip another header (20 bytes) plus the following
6 32bit values.
| rofl0r | 2013-11-04 | 1 | -1/+1 |
| * | fix timezone parser code crashing on 64bit sys•••if sizeof(time_t) == 8, this code path was missing the correct
offset into the zoneinfo file, using the header magic to do
offset calculations.
the 6 32bit fields to be read start at offset 20.
| rofl0r | 2013-11-04 | 1 | -1/+1 |
| * | fix regression in inet_aton due to misinterpretation of __ipparse return•••inet_aton returns a boolean success value, whereas __ipparse returns 0
on success and -1 on failure. also change the conditional in inet_addr
to be consistent with other uses of __ipparse where only negative
values are treated as failure.
| Rich Felker | 2013-11-02 | 2 | -3/+3 |
| * | simplify faccessat AT_EACCESS path and eliminate resource dependence•••now that we're waiting for the exit status of the child process, the
result can be conveyed in the exit status rather than via a pipe.
since the error value might not fit in 7 bits, a table is used to
translate possible meaningful error values to small integers.
| Rich Felker | 2013-11-01 | 1 | -14/+21 |
| * | fix faccessat AT_EACCESS path not to leave zombie processes•••I mistakenly assumed that clone without a signal produced processes
that would not become zombies; however, waitpid with __WCLONE is
required to release their pids.
| Rich Felker | 2013-11-01 | 1 | -2/+6 |
| * | POSIX conformance fix: define struct entry in search.h | Szabolcs Nagy | 2013-10-29 | 1 | -8/+8 |
| * | fenv: fix i386 fesetround for sse•••i386 fenv code checks __hwcap for sse support, but in fesetround the sse
code was unconditionally jumped over after the test so the sse rounding
mode was never set.
| Szabolcs Nagy | 2013-10-28 | 1 | -1/+1 |
| * | math: extensive log*.c cleanup•••The log, log2 and log10 functions share a lot of code and to a lesser
extent log1p too. A small part of the code was kept separately in
__log1p.h, but since it did not capture much of the common code and
it was inlined anyway, it did not solve the issue properly. Now the
log functions have significant code duplication, which may be resolved
later, until then they need to be modified together.
logl, log10l, log2l, log1pl:
* Fix the sign when the return value should be -inf.
* Remove the volatile hack from log10l (seems unnecessary)
log1p, log1pf:
* Change the handling of small inputs: only |x|<2^-53 is special
(then it is enough to return x with the usual subnormal handling)
this fixes the sign of log1p(0) in downward rounding.
* Do not handle the k==0 case specially (other than skipping the
elaborate argument reduction)
* Do not handle 1+x close to power-of-two specially (this code was
used rarely, did not give much speed up and the precision wasn't
better than the general)
* Fix the correction term formula (c=1-(u-x) was used incorrectly
when x<1 but (double)(x+1)==2, this was not a critical issue)
* Use the exact same method for calculating log(1+f) as in log
(except in log1p the c correction term is added to the result).
log, logf, log10, log10f, log2, log2f:
* Use double_t and float_t consistently.
* Now the first part of log10 and log2 is identical to log (until the
return statement, hopefully this makes maintainence easier).
* Most special case formulas were removed (close to power-of-two and
k==0 cases), they increase the code size without providing precision
or performance benefits (and obfuscate the code).
Only x==1 is handled specially so in downward rounding mode the
sign of zero is correct (the general formula happens to give -0).
* For x==0 instead of -1/0.0 or -two54/0.0, return -1/(x*x) to force
raising the exception at runtime.
* Arg reduction code is changed (slightly simplified)
* The thresholds for arg reduction to [sqrt(2)/2,sqrt(2)] are now
consistently the [0x3fe6a09e00000000,0x3ff6a09dffffffff] and the
[0x3f3504f3,0x3fb504f2] intervals for double and float reductions
respectively (the exact threshold values are not critical)
* Remove the obsolete comment for the FLT_EVAL_METHOD!=0 case in log2f
(The same code is used for all eval methods now, on i386 slightly
simpler code could be used, but we have asm there anyway)
all:
* Fix signed int arithmetics (using unsigned for bitmanipulation)
* Fix various comments
| Szabolcs Nagy | 2013-10-28 | 14 | -583/+369 |
| * | add legacy ftime function and sys/timeb.h•••despite being marked legacy, this was specified by SUSv3 as part of
the XSI option; only the most recent version of the standard dropped
it. reportedly there's actual code using it.
| Rich Felker | 2013-10-25 | 1 | -0/+12 |
| * | fix inet_pton•••* parse IPv4 dotted-decimal correctly (without strtoul, no leading zeros)
* disallow single leading ':' in IPv6 address
* allow at most 4 hex digits in IPv6 address (according to RFC 2373)
* have enough hex fields in IPv4 mapped IPv6 address
* disallow leading zeros in IPv4 mapped IPv6 address
| Szabolcs Nagy | 2013-10-23 | 1 | -26/+19 |
| * | fix __ipparse to parse the generic numbers-and-dots IPv4 format correctly•••* allow at most 4 parts
* bounds check the parts correctly
* disallow leading whitespace and sign
* check the address family before falling back to IPv6
| Szabolcs Nagy | 2013-10-22 | 1 | -5/+12 |
| * | fix inet_aton to accept the generic "numbers-and-dots" IPv4 address format | Szabolcs Nagy | 2013-10-22 | 1 | -1/+4 |
| * | split inet_addr and inet_ntoa back into their own files•••despite being practically deprecated, these functions are still part
of the standard and thus cannot reside in a file that also contains
namespace pollution. this reverts some of the changes made in commit
e40f48a421a9176e3e298b5bac75f0355b219e58.
| Rich Felker | 2013-10-21 | 3 | -16/+21 |
| * | fix return value for inet_pton in ipv6 failure cases•••in the case of input that does not match the expected form, the
correct return value is 0, not -1.
| Rich Felker | 2013-10-19 | 1 | -6/+6 |
| * | in faccessat slow path, add close-on-exec to pipe fds•••as usual, this is needed to avoid fd leaks. as a better solution, the
use of fds could possibly be replaced with mmap and a futex.
| Rich Felker | 2013-10-18 | 1 | -1/+1 |
| * | fix uid/gid-setting error in faccessat with AT_EACCESS flag•••this fixes an issue reported by Daniel Thau whereby faccessat with the
AT_EACCESS flag did not work in cases where the process is running
suid or sgid but without root privileges. per POSIX, when the process
does not have "appropriate privileges", setuid changes the euid, not
the real uid, and the target uid must be equal to the current real or
saved uid; if this condition is not met, EPERM results. this caused
the faccessat child process to fail.
using the setreuid syscall rather than setuid works. POSIX leaves it
unspecified whether setreuid can set the real user id to the effective
user id on processes without "appropriate privileges", but Linux
allows this; if it's not allowed, there would be no way for this
function to work.
| Rich Felker | 2013-10-12 | 1 | -2/+2 |
| * | fix errno value for getcwd when size argument is zero•••based on patch by Michael Forney. at the same time, I've changed the
if branch to be more clear, avoiding the comma operator.
the underlying issue is that Linux always returns ERANGE when size is
too short, even when it's zero, rather than returning EINVAL for the
special case of zero as required by POSIX.
| Rich Felker | 2013-10-08 | 1 | -1/+7 |
| * | math: fix rare underflow issue in fma•••the issue is described in commits 1e5eb73545ca6cfe8b918798835aaf6e07af5beb
and ffd8ac2dd50f99c3c83d7d9d845df9874ec3e7d5
| Szabolcs Nagy | 2013-10-07 | 3 | -13/+55 |
| * | math: use sqrtl if FLT_EVAL_METHOD==2 in acosh and acoshf•••this makes acosh slightly more precise around 1.0 on i386
| Szabolcs Nagy | 2013-10-07 | 2 | -0/+13 |
| * | remove errno setting from setenv, malloc sets it correctly on oom | Szabolcs Nagy | 2013-10-07 | 1 | -1/+0 |
| * | fix allocation sizes in regcomp•••sizeof had incorrect argument in a few places, the size was always
large enough so the issue was not critical.
| Szabolcs Nagy | 2013-10-07 | 1 | -4/+4 |
| * | add missing va_end in execl* for correcness and static code analyzers | Szabolcs Nagy | 2013-10-07 | 3 | -0/+3 |
| * | minor vfprintf and vfwprintf changes to please static code analyzers•••add missing va_end and remove some unnecessary code.
| Szabolcs Nagy | 2013-10-07 | 2 | -6/+11 |
| * | math: remove an unused variable from modfl | Szabolcs Nagy | 2013-10-06 | 1 | -1/+0 |
| * | slightly optimize __brk for size•••there is no reason to check the return value for setting errno, since
brk never returns errors, only the new value of the brk (which may be
the same as the old, or otherwise differ from the requested brk, on
failure).
it may be beneficial to eventually just eliminate this file and make
the syscalls inline in malloc.c.
| Rich Felker | 2013-10-05 | 1 | -1/+1 |
| * | fix failure of malloc to set errno on heap (brk) exhaustion•••I wrongly assumed the brk syscall would set errno, but on failure it
returns the old value of the brk rather than an error code.
| Rich Felker | 2013-10-05 | 1 | -0/+1 |
| * | fix failure to check malloc result in setenv | Rich Felker | 2013-10-04 | 1 | -9/+9 |
| * | math: remove code duplication in erfl found by clang analyzer•••erfl had some superflous code left around after the last erf cleanup.
the issue was reported by Alexander Monakov
| Szabolcs Nagy | 2013-10-04 | 1 | -13/+2 |
| * | math: remove a useless assignment in lgammal found by clang analyzer•••the issue was reported by Alexander Monakov
| Szabolcs Nagy | 2013-10-04 | 1 | -2/+2 |
| * | fix invalid implicit pointer conversion in pthread_key_create | Rich Felker | 2013-10-04 | 1 | -1/+1 |
| * | fix uninitialized variable in dladdr•••the affected branch only applies for DSOs that lack standard hash
table and only have the GNU hash table present.
| Rich Felker | 2013-10-04 | 1 | -1/+1 |
| * | removed unused variable in vfwprintf | Rich Felker | 2013-10-04 | 1 | -2/+1 |
| * | fix new environment always being null with execle•••the va_arg call for the argv[]-terminating null pointer was missing,
so this pointer was being wrongly used as the environment pointer.
issue reported by Timo Teräs. proposed patch slightly modified to
simplify the resulting code.
| Rich Felker | 2013-10-03 | 1 | -2/+1 |
| * | fix off-by-one error in getgrnam_r and getgrgid_r, clobbering gr_name•••bug report and patch by Michael Forney. the terminating null pointer
at the end of the gr_mem array was overwriting the beginning of the
string data, causing the gr_name member to always be a zero-length
string.
| Rich Felker | 2013-09-29 | 1 | -2/+2 |
| * | fix buffer overflow in mbsrtowcs•••issue reported by Michael Forney:
"If wn becomes 0 after processing a chunk of 4, mbsrtowcs currently
continues on, wrapping wn around to -1, causing the rest of the string
to be processed.
This resulted in buffer overruns if there was only space in ws for wn
wide characters."
the original patch submitted added an additional check for !wn after
the loop; to avoid extra branching, I instead just changed the wn>=4
check to wn>=5 to ensure that at least one slot remains after the
word-at-a-time loop runs. this should not slow down the tail
processing on real-world usage, since an extra slot that can't be
processed in the word-at-a-time loop is needed for the null
termination anyway.
| Rich Felker | 2013-09-27 | 1 | -1/+1 |
| * | fix potential deadlock bug in libc-internal locking logic•••if a multithreaded program became non-multithreaded (i.e. all other
threads exited) while one thread held an internal lock, the remaining
thread would fail to release the lock. the the program then became
multithreaded again at a later time, any further attempts to obtain
the lock would deadlock permanently.
the underlying cause is that the value of libc.threads_minus_1 at
unlock time might not match the value at lock time. one solution would
be returning a flag to the caller indicating whether the lock was
taken and needs to be unlocked, but there is a simpler solution: using
the lock itself as such a flag.
note that this flag is not needed anyway for correctness; if the lock
is not held, the unlock code is harmless. however, the memory
synchronization properties associated with a_store are costly on some
archs, so it's best to avoid executing the unlock code when it is
unnecessary.
| Rich Felker | 2013-09-20 | 3 | -13/+15 |
| * | correct the sysconf value for RTSIG_MAX•••this is the number of realtime signals available, not the maximum
signal number or total number of signals.
| Rich Felker | 2013-09-20 | 1 | -1/+2 |
| * | fix sigemptyset and sigfillset for mips•••they were leaving junk in the upper bits.
| Rich Felker | 2013-09-16 | 2 | -1/+10 |
| * | fix clobbering of caller's stack in mips __clone function•••this was resulting in crashes in posix_spawn on mips, and would have
affected applications calling clone too. since the prototype for
__clone has it as a variadic function, it may not assume that 16($sp)
is writable for use in making the syscall. instead, it needs to
allocate additional stack space, and then adjust the stack pointer
back in both of the code paths for the parent process/thread.
| Rich Felker | 2013-09-16 | 1 | -0/+3 |
| * | omit CLONE_PARENT flag to clone in pthread_create•••CLONE_PARENT is not necessary (CLONE_THREAD provides all the useful
parts of it) and Linux treats CLONE_PARENT as an error in certain
situations, without noticing that it would be a no-op due to
CLONE_THREAD. this error case prevents, for example, use of a
multi-threaded init process and certain usages with containers.
| Rich Felker | 2013-09-16 | 1 | -1/+1 |
| * | use symbolic names for clone flags in pthread_create | Rich Felker | 2013-09-16 | 1 | -2/+5 |
| * | support configurable page size on mips, powerpc and microblaze•••PAGE_SIZE was hardcoded to 4096, which is historically what most
systems use, but on several archs it is a kernel config parameter,
user space can only know it at execution time from the aux vector.
PAGE_SIZE and PAGESIZE are not defined on archs where page size is
a runtime parameter, applications should use sysconf(_SC_PAGE_SIZE)
to query it. Internally libc code defines PAGE_SIZE to libc.page_size,
which is set to aux[AT_PAGESZ] in __init_libc and early in __dynlink
as well. (Note that libc.page_size can be accessed without GOT, ie.
before relocations are done)
Some fpathconf settings are hardcoded to 4096, these should be actually
queried from the filesystem using statfs.
| Szabolcs Nagy | 2013-09-15 | 12 | -11/+24 |
| * | fix overflow in sysconf for _SC_MQ_PRIO_MAX•••the value of MQ_PRIO_MAX does not fit, so it needs to use OFLOW.
| Rich Felker | 2013-09-14 | 1 | -1/+2 |
| * | fix child stack alignment on mips clone•••unlike other archs, the mips version of clone was not doing anything
to align the stack pointer. this seems to have been the cause for some
SIGBUS crashes that were observed in posix_spawn.
| Rich Felker | 2013-09-14 | 1 | -0/+1 |
| * | fix x86_64 lrintl asm, again•••the underlying problem was not incorrect sign extension (fixed in the
previous commit to this file by nsz) but that code that treats "long"
as 32-bit was copied blindly from i386 to x86_64.
now lrintl is identical to llrintl on x86_64, as it should be.
| Rich Felker | 2013-09-13 | 1 | -2/+2 |
| * | do not use default when dynamic linker fails to open existing path file•••if fopen fails for a reason other than ENOENT, we must assume the
intent is that the path file be used. failure may be due to
misconfiguration or intentional resource-exhaustion attack (against
suid programs), in which case falling back to loading libraries from
an unintended path could be dangerous.
| Rich Felker | 2013-09-09 | 1 | -0/+2 |
