| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | fix const-correctness of argument to stime•••it's unclear what the historical signature for this function was, but
semantically, the argument should be a pointer to const, and this is
what glibc uses. correct programs should not be using this function
anyway, so it's unlikely to matter.
| Rich Felker | 2014-01-07 | 1 | -1/+1 |
| * | fix signedness of pgoff argument to remap_file_pages•••both the kernel and glibc agree that this argument is unsigned; the
incorrect type ssize_t came from erroneous man pages.
| Rich Felker | 2014-01-07 | 1 | -1/+1 |
| * | fix const-correctness in sigandset/sigorset arguments•••this change is consistent with the corresponding glibc functions and
is semantically const-correct. the incorrect argument types without
const seem to have been taken from erroneous man pages.
| Rich Felker | 2014-01-07 | 2 | -2/+2 |
| * | fix incorrect type for wd argument of inotify_rm_watch•••this was wrong since the original commit adding inotify, and I don't
see any explanation for it. not even the man pages have it wrong. it
was most likely a copy-and-paste error.
| Rich Felker | 2014-01-07 | 1 | -1/+1 |
| * | fix argument types for legacy function inet_makeaddr•••the type int was taken from seemingly erroneous man pages. glibc uses
in_addr_t (uint32_t), and semantically, the arguments should be
unsigned.
| Rich Felker | 2014-01-06 | 1 | -2/+1 |
| * | eliminate explicit (long) casts when making syscalls•••this practice came from very early, before internal/syscall.h defined
macros that could accept pointer arguments directly and handle them
correctly. aside from being ugly and unnecessary, it looks like it
will be problematic when we add support for 32-bit ABIs on archs where
registers (and syscall arguments) are 64-bit, e.g. x32 and mips n32.
| Rich Felker | 2014-01-06 | 5 | -5/+5 |
| * | const-qualify the address argument to dladdr•••this agrees with implementation practice on glibc and BSD systems, and
is the const-correct way to do things; it eliminates warnings from
passing pointers to const. the prototype without const came from
seemingly erroneous man pages.
| Rich Felker | 2014-01-06 | 2 | -4/+4 |
| * | add some missing LFS64 aliases for fadvise/fallocate functions | Rich Felker | 2014-01-06 | 3 | -0/+10 |
| * | fanotify.c: fix typo in header inclusion•••the header is included only as a guard to check that the declaration
and definition match, so the typo didn't cause any breakage aside
from omitting this check.
| rofl0r | 2014-01-03 | 1 | -1/+1 |
| * | disable the brk function•••the reasons are the same as for sbrk. unlike sbrk, there is no safe
usage because brk does not return any useful information, so it should
just fail unconditionally.
| Rich Felker | 2014-01-02 | 1 | -1/+2 |
| * | disable sbrk for all values of increment except 0•••use of sbrk is never safe; it conflicts with malloc, and malloc may be
used internally by the implementation basically anywhere. prior to
this change, applications attempting to use sbrk to do their own heap
management simply caused untrackable memory corruption; now, they will
fail with ENOMEM allowing the errors to be fixed.
sbrk(0) is still permitted as a way to get the current brk; some
misguided applications use this as a measurement of their memory
usage or for other related purposes, and such usage is harmless.
eventually sbrk may be re-added if/when malloc is changed to avoid
using the brk by using mmap for all allocations.
| Rich Felker | 2014-01-02 | 1 | -3/+3 |
| * | add fanotify syscall wrapper and header | rofl0r | 2014-01-02 | 1 | -0/+14 |
| * | implement legacy function herror•••based on patch by Timo Teräs; greatly simplified to use fprintf.
| Rich Felker | 2013-12-20 | 1 | -0/+8 |
| * | add sys/quota.h and quotactl syscall wrapper•••based on patch by Timo Teräs.
| Rich Felker | 2013-12-20 | 1 | -0/+7 |
| * | fix failure of fchmod, fstat, fchdir, and fchown to produce EBADF•••the workaround/fallback code for supporting O_PATH file descriptors
when the kernel lacks support for performing these operations on them
caused EBADF to get replaced by ENOENT (due to missing entry in
/proc/self/fd). this is unlikely to affect real-world code (calls that
might yield EBADF are generally unsafe, especially in library code)
but it was breaking some test cases.
the fix I've applied is something of a tradeoff: it adds one syscall
to these operations on kernels where the workaround is needed. the
alternative would be to catch ENOENT from the /proc lookup and
translate it to EBADF, but I want to avoid doing that in the interest
of not touching/depending on /proc at all in these functions as long
as the kernel correctly supports the operations. this is following the
general principle of isolating hacks to code paths that are taken on
broken systems, and keeping the code for correct systems completely
hack-free.
| Rich Felker | 2013-12-19 | 4 | -4/+12 |
| * | fix hangs in localtime for near-overflowing time_t values on 64-bit archs | Rich Felker | 2013-12-19 | 1 | -0/+6 |
| * | fix dynamic linker entry point for microblaze•••the ABI allows the callee to clobber stack slots that correspond to
arguments passed in registers, so the caller must adjust the stack
pointer to reserve space appropriately. prior to this fix, the argv
array was possibly clobbered by dynamic linker code before passing
control to the main program.
| Rich Felker | 2013-12-14 | 1 | -3/+4 |
| * | optimize get_current_dir_name to reduce stack bloat•••our getcwd already (as an extension) supports allocation of a buffer
when the buffer argument is a null pointer, so there's no need to
duplicate the allocation logic in this wrapper function. duplicating
it is actually harmful in that it doubles the stack usage from
PATH_MAX to 2*PATH_MAX.
| Rich Felker | 2013-12-13 | 1 | -3/+1 |
| * | use 0 instead of NULL for null pointer constants•••and thereby remove otherwise-unnecessary inclusion of stddef.h
| Rich Felker | 2013-12-13 | 7 | -15/+8 |
| * | include cleanups: remove unused headers and add feature test macros | Szabolcs Nagy | 2013-12-12 | 157 | -207/+68 |
| * | remove an unnecessary check in inet_pton•••at most 4 hexadecimal digits are processed in one field so the
value cannot overflow. the netdb.h header was not used.
| Szabolcs Nagy | 2013-12-12 | 1 | -2/+1 |
| * | math: define _GNU_SOURCE when implementing non-standard math functions•••this makes the prototypes in math.h are visible so they are checked agaist
the function definitions
| Szabolcs Nagy | 2013-12-12 | 6 | -0/+6 |
| * | add posix_close, accepted for inclusion in the next issue of POSIX•••this is purely a wrapper for close since Linux does not support EINTR
semantics for the close syscall.
| Rich Felker | 2013-12-06 | 1 | -0/+6 |
| * | implement FNM_LEADING_DIR extension flag in fnmatch•••previously this flag was defined and accepted as a no-op, possibly
breaking some software that uses it. given the choice to remove the
definition and possibly break applications that were already working,
or simply implement the feature, the latter turned out to be easy
enough to make the decision easy.
in the case where the FNM_PATHNAME flag is also set, this
implementation is clean and essentially optimal. otherwise, it's an
inefficient "brute force" implementation. at some point, when cleaning
up and refactoring this code, I may add a more direct code path for
handling FNM_LEADING_DIR in the non-FNM_PATHNAME case, but at this
point my main interest is avoiding introducing new bugs in the code
that implements the standard fnmatch features specified by POSIX.
| Rich Felker | 2013-12-02 | 1 | -2/+9 |
| * | add infrastructure to record and report the version of libc.so•••this is still experimental and subject to change. for git checkouts,
an attempt is made to record the exact revision to aid in bug reports
and debugging. no version information is recorded in the static libc.a
or binaries it's linked into.
| Rich Felker | 2013-12-01 | 2 | -2/+19 |
| * | fix fnmatch corner cases related to escaping•••the FNM_PATHNAME logic for advancing by /-delimited components was
incorrect when the / character was escaped (i.e. \/), and a final \ at
the end of pattern was not handled correctly.
| Rich Felker | 2013-12-01 | 1 | -4/+4 |
| * | fix the end of string matching in fnmatch with FNM_PATHNAME•••a '/' in the pattern could be incorrectly matched against the
terminating null byte in the string causing arbitrarily long
sequence of out-of-bounds access in fnmatch("/","",FNM_PATHNAME)
| Szabolcs Nagy | 2013-12-01 | 1 | -2/+2 |
| * | support mix of IPv4 and v6 nameservers in resolv.conf•••a v6 socket will only be used if there is at least one v6 nameserver
address. if the kernel lacks v6 support, the code will fall back to
using a v4 socket and requests to v6 servers will silently fail. when
using a v6 socket, v4 addresses are converted to v4-mapped form and
setsockopt is used to ensure that the v6 socket can accept both v4 and
v6 traffic (this is on-by-default on Linux but the default is
configurable in /proc and so it needs to be set explicitly on the
socket level). this scheme avoids increasing resource usage during
lookups and allows the existing network io loop to be used without
modification.
previously, nameservers whose address family did not match the address
family of the first-listed nameserver were simply ignored. prior to
recent __ipparse fixes, they were not ignored but erroneously parsed.
| Rich Felker | 2013-11-30 | 1 | -5/+31 |
| * | reject invalid address families in getaddrinfo•••subsequent code assumes the address family requested is either
unspecified or one of IPv4/IPv6, and could malfunction if this
constraint is not met, so other address families should be explicitly
rejected.
| Rich Felker | 2013-11-27 | 1 | -0/+3 |
| * | fix off-by-one length failure in strftime/wcsftime and improve error behavior•••these functions were spuriously failing in the case where the buffer
size was exactly the number of bytes/characters to be written,
including null termination. since these functions do not have defined
error conditions other than buffer size, a reasonable application may
fail to check the return value when the format string and buffer size
are known to be valid; such an application could then attempt to use a
non-terminated buffer.
in addition to fixing the bug, I have changed the error handling
behavior so that these functions always null-terminate the output
except in the case where the buffer size is zero, and so that they
always write as many characters as possible before failing, rather
than dropping whole fields that do not fit. this actually simplifies
the logic somewhat anyway.
| Rich Felker | 2013-11-26 | 2 | -12/+16 |
| * | remove duplicate includes from dynlink.c, strfmon.c and getaddrinfo.c | Szabolcs Nagy | 2013-11-25 | 3 | -7/+0 |
| * | shadow: Implement fgetspent | Michael Forney | 2013-11-24 | 1 | -1/+10 |
| * | shadow: Move spent parsing to internal function | Michael Forney | 2013-11-24 | 2 | -31/+40 |
| * | Fix dn_comp prototype and add stub•••This function is used by ping6 from iputils.
| Michael Forney | 2013-11-24 | 1 | -0/+9 |
| * | shadow: Implement putspent | Michael Forney | 2013-11-24 | 2 | -5/+13 |
| * | math: clean up __rem_pio2•••- remove the HAVE_EFFICIENT_IRINT case: fn is an exact integer, so
it can be converted to int32_t a bit more efficiently than with a
cast (the rounding mode change can be avoided), but musl does not
support this case on any arch.
- __rem_pio2: use double_t where possible
- __rem_pio2f: use less assignments to avoid stores on i386
- use unsigned int bit manipulation (and union instead of macros)
- use hexfloat literals instead of named constants
| Szabolcs Nagy | 2013-11-24 | 3 | -71/+53 |
| * | Fix dn_expand pointer following | Michael Forney | 2013-11-23 | 1 | -1/+1 |
| * | putgrent: Add missing newline | Michael Forney | 2013-11-23 | 1 | -0/+1 |
| * | putgrent: Stop writing output on first failure•••This way, if an fprintf fails, we get an incomplete group entry rather
than a corrupted one.
| Michael Forney | 2013-11-23 | 1 | -2/+3 |
| * | strcmp: Remove unnecessary check for *r•••If *l == *r && *l, then by transitivity, *r.
| Michael Forney | 2013-11-23 | 1 | -1/+1 |
| * | fix and refactor child reaping logic in wordexp•••loop condition was incorrect and confusing and caused an infinite loop
when (broken) applications reaped the pid from a signal handler or
another thread before wordexp's call to waitpid could do so.
| Rich Felker | 2013-11-22 | 1 | -6/+16 |
| * | fix fd leak and case where fd 1 is already closed in wordexp | Rich Felker | 2013-11-22 | 1 | -4/+4 |
| * | fix resource exhaustion and zero-word cases in wordexp•••when WRDE_NOSPACE is returned, the we_wordv and we_wordc members must
be valid, because the interface contract allows them to return partial
results.
in the case of zero results (due either to resource exhaustion or a
zero-word input) the we_wordv array still should contain a terminating
null pointer and the initial we_offs null pointers. this is impossible
on resource exhaustion, so a correct application must presumably check
for a null pointer in we_wordv; POSIX however seems to ignore the
issue. the previous code may have crashed under this situation.
| Rich Felker | 2013-11-22 | 1 | -8/+18 |
| * | improve robustness of wordexp and fix handling of 0-word case•••avoid using exit status to determine if a shell error occurred, since
broken programs may install SIGCHLD handlers which reap all zombies,
including ones that don't belong to them. using clone and __WCLONE
does not seem to work for avoiding this problem since exec resets the
exit signal to SIGCHLD.
instead, the new code uses a dummy word at the beginning of the
shell's output, which is ignored, to determine whether the command was
executed successfully. this also fixes a corner case where a word
string containing zero words was interpreted as a single zero-length
word rather than no words at all. POSIX does not seem to require this
case to be supported anyway, though.
in addition, the new code uses the correct retry idiom for waitpid to
ensure that spurious STOP/CONT signals in the child and/or EINTR in
the parent do not prevent successful wait for the child, and blocks
signals in the child.
| Rich Felker | 2013-11-22 | 1 | -11/+16 |
| * | add legacy getloadavg api | Szabolcs Nagy | 2013-11-21 | 1 | -0/+18 |
| * | fix fd leak (missing close-on-exec) in getifaddrs | Rich Felker | 2013-11-20 | 1 | -1/+1 |
| * | math: add (obsolete) bsd drem and finite functions | Szabolcs Nagy | 2013-11-21 | 4 | -0/+20 |
| * | math: lgamma cleanup (simpler sin(pi*x) for the negative case)•••* simplify sin_pi(x) (don't care about inexact here, the result is
inexact anyway, and x is not so small to underflow)
* in lgammal add the previously removed special case for x==1 and
x==2 (to fix the sign of zero in downward rounding mode)
* only define lgammal on supported long double platforms
* change tgamma so the generated code is a bit smaller
| Szabolcs Nagy | 2013-11-21 | 4 | -202/+110 |
| * | iswspace: fix handling of 0 | rofl0r | 2013-11-11 | 1 | -2/+1 |
| * | fix harmless inconsistency in semtimedop•••this should not matter since the reality is that either all the sysv
sem syscalls are individual syscalls, or all of them are multiplexed
on the SYS_ipc syscall (depending on arch). but best to be consistent
anyway.
| Rich Felker | 2013-11-09 | 1 | -1/+1 |
