diff options
| -rw-r--r-- | sqlite3.go | 12 | ||||
| -rw-r--r-- | sqlite3_test.go | 15 |
2 files changed, 23 insertions, 4 deletions
@@ -1511,11 +1511,15 @@ func (s *SQLiteStmt) bind(args []namedValue) error { case float64: rv = C.sqlite3_bind_double(s.s, n, C.double(v)) case []byte: - ln := len(v) - if ln == 0 { - v = placeHolder + if v == nil { + rv = C.sqlite3_bind_null(s.s, n) + } else { + ln := len(v) + if ln == 0 { + v = placeHolder + } + rv = C._sqlite3_bind_blob(s.s, n, unsafe.Pointer(&v[0]), C.int(ln)) } - rv = C._sqlite3_bind_blob(s.s, n, unsafe.Pointer(&v[0]), C.int(ln)) case time.Time: b := []byte(v.Format(SQLiteTimestampFormats[0])) rv = C._sqlite3_bind_text(s.s, n, (*C.char)(unsafe.Pointer(&b[0])), C.int(len(b))) diff --git a/sqlite3_test.go b/sqlite3_test.go index 782f57c..1013d34 100644 --- a/sqlite3_test.go +++ b/sqlite3_test.go @@ -1580,6 +1580,21 @@ func TestNilAndEmptyBytes(t *testing.T) { } } +func TestInsertNilByteSlice(t *testing.T) { + db, err := sql.Open("sqlite3", ":memory:") + if err != nil { + t.Fatal(err) + } + defer db.Close() + if _, err := db.Exec("create table blob_not_null (b blob not null)"); err != nil { + t.Fatal(err) + } + var nilSlice []byte + if _, err := db.Exec("insert into blob_not_null (b) values (?)", nilSlice); err == nil { + t.Fatal("didn't expect INSERT to 'not null' column with a nil []byte slice to work") + } +} + var customFunctionOnce sync.Once func BenchmarkCustomFunctions(b *testing.B) { |