bin/: Use explicit "--" separator for assert-arg usages

In order to prevent legitimate cases to fail as errors, such as:

  NUM='-10'
  eval "$(assert-arg "$NUM" '-n NUM')"

To prevent assert-arg(1) from treating "-10" as the options "-1 and -0,
they need to be put after the "--" separator.

This way, all usages of assert-arg(1) that had its first argument as a
variable were adapted, and the usage and examples of assert-arg itself
were updated to encourage this best practice.

1 files changed, 1 insertions, 1 deletions

diff --git a/bin/ootb b/bin/ootb
index 3aa58db..2b98454 100755
--- a/bin/ootb
+++ b/bin/ootb
@@ -93,7 +93,7 @@ shift $((OPTIND - 1))
 
 
 BUILD_DIRECTORY="${1:-}"
-eval "$(assert-arg "$BUILD_DIRECTORY" 'BUILD_DIRECTORY')"
+eval "$(assert-arg -- "$BUILD_DIRECTORY" 'BUILD_DIRECTORY')"
 mkdir -p "$BUILD_DIRECTORY"