diff options
| author | sasha-s <sasha@scaledinference.com> | 2015-03-26 16:47:24 -0700 |
|---|---|---|
| committer | sasha-s <sasha@scaledinference.com> | 2015-04-16 11:58:02 -0700 |
| commit | bdc109bdc7dcb4ec98de9605c24fbd9afef5f3bc (patch) | |
| tree | 38d96eae84b1726d713debd9725dcf2b27dc398b /bolt_amd64.go | |
| parent | Add --path to bolt bench. (diff) | |
| download | dedo-bdc109bdc7dcb4ec98de9605c24fbd9afef5f3bc.tar.gz dedo-bdc109bdc7dcb4ec98de9605c24fbd9afef5f3bc.tar.xz | |
fix `slice bounds out of range`/maxAllocSize bugs
when accessing the node data we used to use cast to
*[maxAllocSize]byte, which breaks if we try to go across maxAllocSize boundary.
This leads to occasional panics.
Sample stacktrace:
```
panic: runtime error: slice bounds out of range
goroutine 1 [running]:
github.com/boltdb/bolt.(*node).write(0xc208010f50, 0xc27452a000)
$GOPATH/src/github.com/boltdb/bolt/node.go:228 +0x5a5
github.com/boltdb/bolt.(*node).spill(0xc208010f50, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/node.go:364 +0x506
github.com/boltdb/bolt.(*node).spill(0xc208010700, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/node.go:336 +0x12d
github.com/boltdb/bolt.(*node).spill(0xc208010620, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/node.go:336 +0x12d
github.com/boltdb/bolt.(*Bucket).spill(0xc22b6ae880, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/bucket.go:535 +0x1c4
github.com/boltdb/bolt.(*Bucket).spill(0xc22b6ae840, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/bucket.go:502 +0xac2
github.com/boltdb/bolt.(*Bucket).spill(0xc22f4e2018, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/bucket.go:502 +0xac2
github.com/boltdb/bolt.(*Tx).Commit(0xc22f4e2000, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/tx.go:150 +0x1ee
github.com/boltdb/bolt.(*DB).Update(0xc2080e4000, 0xc24d077508, 0x0, 0x0)
$GOPATH/src/github.com/boltdb/bolt/db.go:483 +0x169
```
It usually happens when working with large (50M/100M) values.
One way to reproduce it is to change maxAllocSize in bolt_amd64.go to 70000 and run the tests.
TestBucket_Put_Large crashes.
Diffstat (limited to 'bolt_amd64.go')
| -rw-r--r-- | bolt_amd64.go | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/bolt_amd64.go b/bolt_amd64.go index cca6b7e..83f935f 100644 --- a/bolt_amd64.go +++ b/bolt_amd64.go @@ -5,3 +5,7 @@ const maxMapSize = 0xFFFFFFFFFFFF // 256TB // maxAllocSize is the size used when creating array pointers. const maxAllocSize = 0x7FFFFFFF + +// Setting +// const maxAllocSize = 70000 +// reveals the index out of bound bug(s) |