diff options
author | Tommi Virtanen <tv@eagain.net> | 2014-03-22 20:45:53 -0700 |
---|---|---|
committer | Tommi Virtanen <tv@eagain.net> | 2014-03-22 20:47:08 -0700 |
commit | 5ce378b046e500eadd1fb53e1b1488488488ce1f (patch) | |
tree | dc70a4ab70954fa2eed179ebfb1472c700086946 | |
parent | Merge pull request #74 from benbjohnson/cli (diff) | |
download | dedo-5ce378b046e500eadd1fb53e1b1488488488ce1f.tar.gz dedo-5ce378b046e500eadd1fb53e1b1488488488ce1f.tar.xz |
Call fdatasync/fsync after writing out non-meta pages
This avoids a case where writes can be reordered so meta page is
written before a page it refers to, potentially causing a corrupt
database after a power loss or kernel crash.
-rw-r--r-- | sync_linux.go | 10 | ||||
-rw-r--r-- | sync_std.go | 10 | ||||
-rw-r--r-- | tx.go | 3 |
3 files changed, 23 insertions, 0 deletions
diff --git a/sync_linux.go b/sync_linux.go new file mode 100644 index 0000000..351b65a --- /dev/null +++ b/sync_linux.go @@ -0,0 +1,10 @@ +package bolt + +import ( + "os" + "syscall" +) + +func fdatasync(f *os.File) error { + return syscall.Fdatasync(int(f.Fd())) +} diff --git a/sync_std.go b/sync_std.go new file mode 100644 index 0000000..d858b23 --- /dev/null +++ b/sync_std.go @@ -0,0 +1,10 @@ +// +build !linux + +package bolt + +import "os" + +// Fall back to syncing metadata too. +func fdatasync(f *os.File) error { + return f.Sync() +} @@ -329,6 +329,9 @@ func (t *Tx) write() error { return err } } + if err := fdatasync(t.db.file); err != nil { + return err + } // Clear out page cache. t.pages = make(map[pgid]*page) |