From 88f83624dc6d7c3b66a34c7c3f414719530e421f Mon Sep 17 00:00:00 2001
From: Ryo Nihei <nihei.dev@gmail.com>
Date: Sat, 17 Apr 2021 22:51:06 +0900
Subject: Add validation of lexical specs and improve error messages

---
 cli/cmd/compile.go | 42 ++++++++++++++++++++++++++++--------------
 1 file changed, 28 insertions(+), 14 deletions(-)

(limited to 'cli/cmd/compile.go')

diff --git a/cli/cmd/compile.go b/cli/cmd/compile.go
index 7815129..6ad64b6 100644
--- a/cli/cmd/compile.go
+++ b/cli/cmd/compile.go
@@ -25,23 +25,16 @@ func init() {
 }
 
 func runCompile(cmd *cobra.Command, args []string) (retErr error) {
-	var lspec *spec.LexSpec
-	{
-		data, err := ioutil.ReadAll(os.Stdin)
-		if err != nil {
-			return err
-		}
-		lspec = &spec.LexSpec{}
-		err = json.Unmarshal(data, lspec)
-		if err != nil {
-			return err
-		}
+	lspec, err := readLexSpec()
+	if err != nil {
+		return fmt.Errorf("Cannot read a lexical specification: %w", err)
 	}
 	var w io.Writer
 	{
-		f, err := os.OpenFile("maleeni-compile.log", os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
+		fileName := "maleeni-compile.log"
+		f, err := os.OpenFile(fileName, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0644)
 		if err != nil {
-			return err
+			return fmt.Errorf("Cannot open the log file %s: %w", fileName, err)
 		}
 		defer f.Close()
 		w = f
@@ -62,11 +55,32 @@ Date time: %v
 	if err != nil {
 		return err
 	}
+	err = writeCompiledLexSpec(clspec)
+	if err != nil {
+		return fmt.Errorf("Cannot write a compiled lexical specification: %w", err)
+	}
+
+	return nil
+}
+
+func readLexSpec() (*spec.LexSpec, error) {
+	data, err := ioutil.ReadAll(os.Stdin)
+	if err != nil {
+		return nil, err
+	}
+	lspec := &spec.LexSpec{}
+	err = json.Unmarshal(data, lspec)
+	if err != nil {
+		return nil, err
+	}
+	return lspec, nil
+}
+
+func writeCompiledLexSpec(clspec *spec.CompiledLexSpec) error {
 	out, err := json.Marshal(clspec)
 	if err != nil {
 		return err
 	}
 	fmt.Fprintf(os.Stdout, "%v\n", string(out))
-
 	return nil
 }
-- 
cgit v1.2.3