From 6bacf5ed88f3f5706567cd51891e2b1287a44b63 Mon Sep 17 00:00:00 2001 From: EuAndreh Date: Sun, 6 Jun 2021 17:28:02 -0300 Subject: TODOs.md: Mark #task-4686d9a5-3514-e7f2-25de-b3cf66199124 as DONE --- TODOs.md | 18 ++++++++++++++++-- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/TODOs.md b/TODOs.md index 8fd5985..151fd7c 100644 --- a/TODOs.md +++ b/TODOs.md @@ -13,7 +13,6 @@ Done in [`9a9ec634d560b458b216bd1c2a7033c0b7d78339`](https://git.euandreh.xyz/remembering/commit/?id=9a9ec634d560b458b216bd1c2a7033c0b7d78339). - - TODO in 2021-06-06 --- @@ -23,7 +22,22 @@ What about the C implementation? It would be good to have a test stressing that. -## TODO Use POSIX `$(CFLAGS)` {#task-4686d9a5-3514-e7f2-25de-b3cf66199124} +## DONE Use POSIX `$(CFLAGS)` {#task-4686d9a5-3514-e7f2-25de-b3cf66199124} +- DONE in 2021-06-06 + + - `-std=c99` is interpreted as `-s` + `td=c99`, and a `-t` flag doesn't exist. + Since I'm calling the `c99` command, it implies the C99 C standard, and the consumer should make sure of that. + - `-W*` doesn't exist, neither for `-Wall` nor for `-Wl,-rpath,$$LIBRARY_PATH`; + - `-fPIC` doesn't exist; + - `-O3` is optional and "may be supported". + I picked `-O1` which is defined by the specification, without meaning of which optimizations will be performed; + + I can also have all of this overriden in development with `make -e`, and switch compilers and flags for different errors, warnings, etc. + + Consumers can do the same with `make CFLAGS='...'` and similar strategies. + + Done in + [`107d9fa6012a9312bcee9da0bf86e6fa7a34cfef`](https://git.euandreh.xyz/remembering/commit/?id=107d9fa6012a9312bcee9da0bf86e6fa7a34cfef). - TODO in 2021-06-06 --- -- cgit v1.2.3