From 21646d52aef5472a47a5cbbf9342b1ee91f466e8 Mon Sep 17 00:00:00 2001 From: EuAndreh Date: Sun, 6 Jun 2021 17:05:46 -0300 Subject: TODOs.md: Mark #task-19f9d131-696a-3417-c052-6312f04a33af as DONE --- TODOs.md | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/TODOs.md b/TODOs.md index 5f481ce..8fd5985 100644 --- a/TODOs.md +++ b/TODOs.md @@ -1,6 +1,19 @@ # Tasks -## TODO What about UTF-8? {#task-19f9d131-696a-3417-c052-6312f04a33af} +## DONE What about UTF-8? {#task-19f9d131-696a-3417-c052-6312f04a33af} +- DONE in 2021-06-06 + + A `test_utf8_commands` was added to verify the behaviour. + Apparently, the current sh code already passes that. + Since I'm not doing any significant string manipulation other than splitting by the `:` separator, it is reasonable to expect it already to work. + + This may also be true for the C implementation: by not really manipulating the string, everything after the `:` separator can be its own thing, and not be handled by remembering at all. + The current code does not really implement that, as test/*.sh isn't even run against it. + But at least the test is already in place so that it prevents regressions from the reimplementation. + + Done in + [`9a9ec634d560b458b216bd1c2a7033c0b7d78339`](https://git.euandreh.xyz/remembering/commit/?id=9a9ec634d560b458b216bd1c2a7033c0b7d78339). + - TODO in 2021-06-06 --- -- cgit v1.2.3