| Commit message (Expand) | Author | Files | Lines |
|---|
| 2016-12-06 | remove largish unused field from pthread structure | Rich Felker | 1 | -1/+0 |
| 2016-11-12 | work around gdb issues recognizing sigreturn trampoline on x86_64•••gdb can only backtrace/unwind across signal handlers if it recognizes
the sa_restorer trampoline. for x86_64, gdb first attempts to
determine the symbol name for the function in which the program
counter resides and match it against "__restore_rt". if no name can be
found (e.g. in the case of a stripped binary), the exact instruction
sequence is matched instead.
when matching the function name, however, gdb's unwind code wrongly
considers the interval [sym,sym+size] rather than [sym,sym+size).
thus, if __restore_rt begins immediately after another function, gdb
wrongly identifies pc as lying within the previous adjacent function.
this patch adds a nop before __restore_rt to preclude that
possibility. it also removes the symbol name __restore and replaces it
with a macro since the stability of whether gdb identifies the
function as __restore_rt or __restore is not clear.
for the no-symbols case, the instruction sequence is changed to use
%rax rather than %eax to match what gdb expects.
based on patch by Szabolcs Nagy, with extended description and
corresponding x32 changes added.
| Rich Felker | 4 | -8/+24 |
| 2016-11-11 | add s390x port | Bobby Bingham | 42 | -0/+1393 |
| 2016-11-11 | treat null vdso base same as missing•••On s390x, the kernel provides AT_SYSINFO_EHDR, but sets it to zero, if the
program being run does not have a program interpreter. This causes
problems when running the dynamic linker directly.
| Bobby Bingham | 2 | -1/+2 |
| 2016-11-11 | generalize ELF hash table types not to assume 32-bit entries•••alpha and s390x gratuitously use 64-bit entries (wasting 2x space and
cache utilization) despite the values always being 32-bit.
based on patch by Bobby Bingham, with changes suggested by Alexander
Monakov to use the public Elf_Symndx type from link.h (and make it
properly variable by arch) rather than adding new internal
infrastructure for handling the type.
| Rich Felker | 4 | -5/+6 |
| 2016-11-08 | fix build regression on archs with variable page size•••commit 31fb174dd295e50f7c5cf18d31fcfd5fe5a063b7 used
DEFAULT_GUARD_SIZE from pthread_impl.h in a static initializer,
breaking build on archs where its definition, PAGE_SIZE, is not a
constant. instead, just define DEFAULT_GUARD_SIZE as 4096, the minimal
page size on any arch we support. pthread_create rounds up to whole
pages anyway, so defining it to 1 would also work, but a moderately
meaningful value is nicer to programs that use
pthread_attr_getguardsize on default-initialized attribute objects.
| Rich Felker | 1 | -1/+1 |
| 2016-11-08 | add limited pthread_setattr_default_np API to set stack size defaults•••based on patch by Timo Teräs:
While generally this is a bad API, it is the only existing API to
affect c++ (std::thread) and c11 (thrd_create) thread stack size.
This patch allows applications only to increate stack and guard
page sizes.
| Rich Felker | 3 | -4/+45 |
| 2016-11-08 | fix pthread_create regression from stack/guard size simplification•••commit 33ce920857405d4f4b342c85b74588a15e2702e5 broke pthread_create
in the case where a null attribute pointer is passed; rather than
using the default sizes, sizes of 0 (plus the remainder of one page
after TLS/TCB use) were used.
| Rich Felker | 1 | -1/+4 |
| 2016-11-07 | make netinet/in.h suppress clashing definitions from kernel headers•••the linux kernel uapi headers provide their own definitions of the
structures from netinet/in.h, resulting in errors when a program
includes both the standard libc header and one or more of the
networking-related kernel headers that pull in the kernel definitions.
as before, we do not attempt to support the case where kernel headers
are included before the libc ones, since the kernel definitions may
have subtly incorrect types, namespace violations, etc. however, we
can easily support the inclusion of the kernel headers after the libc
ones, since the kernel headers provide a public interface for
suppressing their definitions. this patch adds the necessary macro
definitions for such suppression.
| Rich Felker | 1 | -0/+15 |
| 2016-11-07 | simplify pthread_attr_t stack/guard size representation•••previously, the pthread_attr_t object was always initialized all-zero,
and stack/guard size were represented as differences versus their
defaults. this required lots of confusing offset arithmetic everywhere
they were used. instead, have pthread_attr_init fill in the default
values, and work with absolute sizes everywhere.
| Rich Felker | 7 | -11/+13 |
| 2016-11-07 | fix swprintf internal buffer state and error handling•••the swprintf write callback never reset its buffer pointers, so after
its 256-byte buffer filled up, it would keep repeating those bytes
over and over in the output until the destination buffer filled up. it
also failed to set the error indicator for the stream on EILSEQ,
potentially allowing output to continue after the error.
| Rich Felker | 1 | -1/+8 |
| 2016-11-07 | fix integer overflow of tm_year in __secs_to_tm•••the overflow check for years+100 did not account for the extra
year computed from the remaining months. instead, perform this
check after obtaining the final number of years.
| Daniel Sabogal | 1 | -4/+5 |
| 2016-11-07 | fix ldso reserved library name handling•••If a DT_NEEDED entry was the prefix of a reserved library name
(up to the first dot) then it was incorrectly treated as a libc
reserved name.
e.g. libp.so dependency was not loaded as it matched libpthread
reserved name.
| Szabolcs Nagy | 1 | -19/+19 |
| 2016-11-07 | fix accidental global static pointer in ldso•••this was harmless as load_library is not called concurrently,
but it used one word of bss.
| Szabolcs Nagy | 1 | -1/+2 |
| 2016-11-07 | don't claim support for resolv.h APIs that aren't supported•••the value 19991006 for __RES implies availability of res_ninit and
related functions that take a resolver state argument; these are not
supported since our resolver is stateless. instead claim support for
just the older API by defining __RES to 19960801.
based on patch by Dmitrij D. Czarkoff.
| Rich Felker | 1 | -1/+1 |
| 2016-11-07 | fix parsing of quoted time zone names•••Fix parsing of the < > quoted time zone names. Compare the correct
character instead of repeatedly comparing the first character.
| Hannu Nyman | 1 | -1/+1 |
| 2016-11-07 | remove redundant feature test macro checks in sys/time.h•••this header is XSI-shaded itself and thus does not need to limit
specific content to _XOPEN_SOURCE.
| Rich Felker | 1 | -5/+0 |
| 2016-10-21 | redesign snprintf without undefined behavior•••the old snprintf design setup the FILE buffer pointers to point
directly into the destination buffer; if n was actually larger than
the buffer size, the pointer arithmetic to compute the buffer end
pointer was undefined. this affected sprintf, which is implemented in
terms of snprintf, as well as some unusual but valid direct uses of
snprintf.
instead, setup the FILE as unbuffered and have its write function
memcpy to the destination. the printf core sets up its own temporary
buffer for unbuffered streams.
| Rich Felker | 1 | -25/+38 |
| 2016-10-20 | fix various header namespace issues under feature-test-macro control•••reported and changes suggested by Daniel Sabogal.
| Rich Felker | 6 | -7/+18 |
| 2016-10-20 | remove parameter names from public headers•••inclusion of these names was unintentional and in most cases is a
namespace violation. Daniel Sabogal tracked down and reported these.
| Rich Felker | 6 | -9/+9 |
| 2016-10-20 | fix misspelling of a legacy macro name in sys/param.h | Rich Felker | 1 | -1/+1 |
| 2016-10-20 | add missing if_ether.h constants•••ETH_P_HSR (IEC 62439-3 HSRv1) added in
linux 4.7 commit ee1c27977284907d40f7f72c2d078d709f15811f
ETH_P_TSN (IEEE 1722) added in
linux 4.3 commit 1ab1e895492d8084dfc1c854efacde219e56b8c1
this constant breaks the ascending order to match the kernel header
ETH_P_XDSA (Multiplexed DSA protocol) added in
linux 3.18 commit 3e8a72d1dae374cf6fc1dba97cec663585845ff9
| Daniel Sabogal | 1 | -0/+3 |
| 2016-10-20 | add missing if_arp.h constant•••ARPHRD_6LOWPAN (IPv6 over LoWPAN) added in
linux 3.14 commit 0abc652c796dab74d34d60473ec5594cd21620be
| Daniel Sabogal | 1 | -0/+1 |
| 2016-10-20 | fix typo in utmpx.h | Daniel Sabogal | 1 | -1/+1 |
| 2016-10-20 | add missing confstr constants•••the _CS_V6_ENV and _CS_V7_ENV constants are required to be available for use
with confstr. glibc defines these constants with values 1148 and 1149,
respectively.
the only missing (and required) confstr constants are
_CS_POSIX_V7_THREADS_CFLAGS and _CS_POSIX_V7_THREADS_LDFLAGS which remain
unavailable in glibc.
| Daniel Sabogal | 2 | -1/+3 |
| 2016-10-20 | fix minor problem in previous strtod non-nearest rounding bug fix•••commit 6ffdc4579ffb34f4aab69ab4c081badabc7c0a9a set lnz in the code
path for non-zero digits after a huge string of zeros, but the
assignment of dc to lnz truncates if the value of dc does not fit in
int; this is possible for some pathologically long inputs, either via
strings on 64-bit systems or via scanf-family functions.
instead, simply set lnz to match the point at which we add the
artificial trailing 1 bit to simulate nonzero digits after a huge
run of zeros.
| Rich Felker | 1 | -1/+1 |
| 2016-10-20 | fix strtod int optimization in non-nearest rounding mode•••the mid-sized integer optimization relies on lnz set up properly
to mark the last non-zero decimal digit, but this was not done
if the non-zero digit lied outside the KMAX digits of the base
10^9 number representation.
so if the fractional part was a very long list of zeros (>2048*9 on
x86) followed by non-zero digits then the integer optimization could
kick in discarding the tiny non-zero fraction which can mean wrong
result on non-nearest rounding mode.
strtof, strtod and strtold were all affected.
| Szabolcs Nagy | 1 | -1/+4 |
| 2016-10-20 | fix strtod and strtof rounding with many trailing zeros•••in certain cases excessive trailing zeros could cause incorrect
rounding from long double to double or float in decfloat.
e.g. in strtof("9444733528689243848704.000000", 0) the argument
is 0x1.000001p+73, exactly halfway between two representible floats,
this incorrectly got rounded to 0x1.000002p+73 instead of 0x1p+73,
but with less trailing 0 the rounding was fine.
the fix makes sure that the z index always points one past the last
non-zero digit in the base 10^9 representation, this way trailing
zeros don't affect the rounding logic.
| Szabolcs Nagy | 1 | -0/+3 |
| 2016-10-20 | fix gratuitous undefined behavior in strptime•••accessing an object of type const char *restrict as if it had type
char * is not defined.
| Rich Felker | 1 | -2/+7 |
| 2016-10-20 | fix getopt_long_only misinterpreting "--" as an option | Rich Felker | 1 | -1/+1 |
| 2016-10-20 | fix float formatting of some exact halfway cases•••in nearest rounding mode exact halfway cases were not following the
round to even rule if the rounding happened at a base 1000000000 digit
boundary of the internal representation and the previous digit was odd.
e.g. printf("%.0f", 1.5) printed 1 instead of 2.
| Szabolcs Nagy | 1 | -1/+2 |
| 2016-10-20 | add pthread_setname_np•••the thread name is displayed by gdb's "info threads".
| Felix Janda | 2 | -0/+27 |
| 2016-10-20 | fix clock_nanosleep error case•••posix requires that EINVAL be returned if the first parameter specifies
the cpu-time clock of the calling thread (CLOCK_THREAD_CPUTIME_ID).
linux returns ENOTSUP instead so we handle this.
| Daniel Sabogal | 1 | -1/+3 |
| 2016-10-20 | math: fix pow signed shift ub•••j is int32_t and thus j<<31 is undefined if j==1, so j is changed to
uint32_t locally as a quick fix, the generated code is not affected.
(this is a strict conformance fix, future c standard may allow 1<<31,
see DR 463. the bug was inherited from freebsd fdlibm, the proper fix
is to use uint32_t for all bit hacks, but that requires more intrusive
changes.)
reported by Daniel Sabogal
| Szabolcs Nagy | 1 | -2/+2 |
| 2016-10-20 | update icmphdr struct following linux v4.8•••add union field that is used in the kernel for SIT/GRE tunneling ICMPv4
messages. see linux commit 20e1954fe238dbe5f8d3a979e593fe352bd703cf
| Szabolcs Nagy | 1 | -0/+1 |
| 2016-10-20 | add TCP_REPAIR_WINDOW to netinet/tcp.h from linux v4.8•••another kernel internal state exposure for checkpoint-restore.
see linux commit b1ed4c4fa9a5ccf325184fd90edc50978ef6e33a
| Szabolcs Nagy | 1 | -0/+9 |
| 2016-10-20 | add bits/hwcap.h and include it in sys/auxv.h•••aarch64, arm, mips, mips64, mipsn32, powerpc, powerpc64 and sh have
cpu feature bits defined in linux for AT_HWCAP auxv entry, so expose
those in sys/auxv.h
it seems the mips hwcaps were never exposed to userspace neither
by linux nor by glibc, but that's most likely an oversight.
| Szabolcs Nagy | 10 | -0/+138 |
| 2016-10-20 | elf.h: update EM_ elf machine defines and add R_BPF_ defines•••sync with gabi: http://www.sco.com/developers/gabi/latest/ch4.eheader.html
EM_BPF is new in linux v4.8 and officially assigned:
https://lists.iovisor.org/pipermail/iovisor-dev/2016-June/000266.html
added related relocs too.
| Szabolcs Nagy | 1 | -1/+101 |
| 2016-10-20 | add ETH_P_NCSI to netinet/if_ether.h from linux v4.8•••see linux commit 6389eaa7fa9c3ee6c7d39f6087b86660d17236ac
| Szabolcs Nagy | 1 | -0/+1 |
| 2016-10-20 | add sh syscall numbers from linux v4.8•••sh was updated in linux commit 74bdaa611fa69368fb4032ad437af073d31116bd
to have numbers for new syscalls.
| Szabolcs Nagy | 1 | -0/+14 |
| 2016-10-20 | fix preadv2 and pwritev2 syscall numbers on x32 for linux v4.8•••the numbers were wrong in musl, but they were also wrong in the kernel
and got fixed in v4.8 commit 3ebfd81f7fb3e81a754e37283b7f38c62244641a
| Szabolcs Nagy | 1 | -2/+2 |
| 2016-10-20 | use dynamic buffer for getmntent•••overlayfs may have fairly long lines so we use getline to allocate a
buffer dynamically. The buffer will be allocated on first use, expand as
needed, but will never be free'ed.
Downstream bug: http://bugs.alpinelinux.org/issues/5703
Signed-off-by: Natanael Copa <ncopa@alpinelinux.org>
| Natanael Copa | 1 | -4/+13 |
| 2016-10-20 | fix integer overflows and uncaught EOVERFLOW in printf core•••this patch fixes a large number of missed internal signed-overflow
checks and errors in determining when the return value (output length)
would exceed INT_MAX, which should result in EOVERFLOW. some of the
issues fixed were reported by Alexander Cherepanov; others were found
in subsequent review of the code.
aside from the signed overflows being undefined behavior, the
following specific bugs were found to exist in practice:
- overflows computing length of floating point formats with huge
explicit precisions, integer formats with prefix characters and huge
explicit precisions, or string arguments or format strings longer
than INT_MAX, resulted in wrong return value and wrong %n results.
- literal width and precision values outside the range of int were
misinterpreted, yielding wrong behavior in at least one well-defined
case: string formats with precision greater than INT_MAX were
sometimes truncated.
- in cases where EOVERFLOW is produced, incorrect values could be
written for %n specifiers past the point of exceeding INT_MAX.
in addition to fixing these bugs, we now stop producing output
immediately when output length would exceed INT_MAX, rather than
continuing and returning an error only at the end.
| Rich Felker | 2 | -46/+89 |
| 2016-10-19 | fix integer overflow in float printf needed-precision computation•••if the requested precision is close to INT_MAX, adding
LDBL_MANT_DIG/3+8 overflows. in practice the resulting undefined
behavior manifests as a large negative result, which is then used to
compute the new end pointer (z) with a wildly out-of-bounds value
(more overflow, more undefined behavior). the end result is at least
incorrect output and character count (return value); worse things do
not seem to happen, but detailed analysis has not been done.
this patch fixes the overflow by performing the intermediate
computation as unsigned; after division by 9, the final result
necessarily fits in int.
| Rich Felker | 1 | -1/+1 |
| 2016-10-06 | fix regexec with haystack strings longer than INT_MAX•••we inherited from TRE regexec code that's utterly wrong with respect
to the integer types it's using. while it doesn't appear that
compilers are producing unsafe output, signed integer overflows seem
to happen, and regexec fails to find matches past offset INT_MAX.
this patch fixes the type of all variables/fields used to store
offsets in the string from int to regoff_t. after the changes, basic
testing showed that regexec can now find matches past 2GB (INT_MAX)
and past 4GB on x86_64, and code generation is unchanged on i386.
| Rich Felker | 1 | -26/+28 |
| 2016-10-06 | fix missing integer overflow checks in regexec buffer size computations•••most of the possible overflows were already ruled out in practice by
regcomp having already succeeded performing larger allocations.
however at least the num_states*num_tags multiplication can clearly
overflow in practice. for safety, check them all, and use the proper
type, size_t, rather than int.
also improve comments, use calloc in place of malloc+memset, and
remove bogus casts.
| Rich Felker | 1 | -5/+18 |
| 2016-10-06 | fix strftime %y for negative tm_year | Szabolcs Nagy | 1 | -0/+1 |
| 2016-09-24 | fix getservby*_r result pointer value on error•••this is a clone of the fix to the gethostby*_r functions in
commit fe82bb9b921be34370e6b71a1c6f062c20999ae0. the man pages
document that the getservby*_r functions set this pointer to
NULL if there was an error or if no record was found.
| Daniel Sabogal | 2 | -0/+3 |
| 2016-09-24 | remove dead case in gethostbyname2_r•••this case statement was accidently left behind when this function
was refactored in commit e8f39ca4898237cf71657500f0b11534c47a0521.
| Daniel Sabogal | 1 | -2/+0 |
| 2016-09-19 | fix undefined behavior in sched.h cpu_set_t usage•••since cpu sets can be dynamically allocated and have variable size,
accessing their contents via ->__bits is not valid; performing pointer
arithmetic outside the range of the size of the declared __bits array
results in undefined beahavior. instead, only use cpu_set_t for
fixed-size cpu set objects (instantiated by the caller) and as an
abstract pointer type for dynamically allocated ones. perform all
accesses simply by casting the abstract pointer type cpuset_t * back
to unsigned long *.
| Rich Felker | 1 | -3/+3 |
