| Commit message (Expand) | Author | Files | Lines |
|---|
| 2013-04-08 | mbrtowc: do not leave mbstate_t in permanent-fail state after EILSEQ•••the standard is clear that the old behavior is conforming: "In this
case, [EILSEQ] shall be stored in errno and the conversion state is
undefined."
however, the specification of mbrtowc has one peculiarity when the
source argument is a null pointer: in this case, it's required to
behave as mbrtowc(NULL, "", 1, ps). no motivation is provided for this
requirement, but the natural one that comes to mind is that the intent
is to reset the mbstate_t object. for stateful encodings, such
behavior is actually specified: "If the corresponding wide character
is the null wide character, the resulting state described shall be the
initial conversion state." but in the case of UTF-8 where the
mbstate_t object contains a partially-decoded character rather than a
shift state, a subsequent '\0' byte indicates that the previous
partial character is incomplete and thus an illegal sequence.
naturally, applications using their own mbstate_t object should clear
it themselves after an error, but the standard presently provides no
way to clear the builtin mbstate_t object used when the ps argument is
a null pointer. I suspect this issue may be addressed in the future by
specifying that a null source argument resets the state, as this seems
to have been the intent all along.
for what it's worth, this change also slightly reduces code size.
| Rich Felker | 1 | -1/+1 |
| 2013-04-08 | implement mbtowc directly, not as a wrapper for mbrtowc•••the interface contract for mbtowc admits a much faster implementation
than mbrtowc can achieve; wrapping mbrtowc with an extra call frame
only made the situation worse.
since the regex implementation uses mbtowc already, this change should
improve regex performance too. it may be possible to improve
performance in other places internally by switching from mbrtowc to
mbtowc.
| Rich Felker | 1 | -5/+39 |
| 2013-04-08 | optimize mbrtowc•••this simple change, in my measurements, makes about a 7% performance
improvement. at first glance this change would seem like a
compiler-specific hack, since the modified code is not even used.
however, I suspect the reason is that I'm eliminating a second path
into the main body of the code, allowing the compiler more flexibility
to optimize the normal (hot) path into the main body. so even if it
weren't for the measurable (and quite notable) difference in
performance, I think the change makes sense.
| Rich Felker | 1 | -3/+2 |
| 2013-04-08 | fix out-of-bounds access in UTF-8 decoding•••SA and SB are used as the lowest and highest valid starter bytes, but
the value of SB was one-past the last valid starter. this caused
access past the end of the state table when the illegal byte '\xf5'
was encountered in a starter position. the error did not show up in
full-character decoding tests, since the bogus state read from just
past the table was unlikely to admit any continuation bytes as valid,
but would have shown up had we tested feeding '\xf5' to the
byte-at-a-time decoding in mbrtowc: it would cause the funtion to
wrongly return -2 rather than -1.
I may eventually go back and remove all references to SA and SB,
replacing them with the values; this would make the code more
transparent, I think. the original motivation for using macros was to
allow misguided users of the code to redefine them for the purpose of
enlarging the set of accepted sequences past the end of Unicode...
| Rich Felker | 1 | -1/+1 |
| 2013-04-07 | fix signalfd not to ignore flags•••also include fallback code for broken kernels that don't support the
flags. as usual, the fallback has a race condition that can leak file
descriptors.
| Rich Felker | 1 | -1/+12 |
| 2013-04-06 | silence nonsensical warnings in timer_create | Rich Felker | 1 | -2/+2 |
| 2013-04-06 | add support for program_invocation[_short]_name•••this is a bit ugly, and the motivation for supporting it is
questionable. however the main factors were:
1. it will be useful to have this for certain internal purposes
anyway -- things like syslog.
2. applications can just save argv[0] in main, but it's hard to fix
non-portable library code that's depending on being able to get the
invocation name without the main application's help.
| Rich Felker | 3 | -2/+18 |
| 2013-04-06 | fix argument omission in ABI-compat weak_alias for fscanf | Rich Felker | 1 | -1/+1 |
| 2013-04-05 | Add ABI compatability aliases.•••GNU used several extensions that were incompatible with C99 and POSIX,
so they used alternate names for the standard functions.
The result is that we need these to run standards-conformant programs
that were linked with glibc.
| Isaac Dunham | 13 | -0/+38 |
| 2013-04-06 | fix type error in pthread_create, introduced with pthread_getattr_np | Rich Felker | 1 | -1/+1 |
| 2013-04-06 | getifaddrs: remove unused label | rofl0r | 1 | -1/+0 |
| 2013-04-05 | getifaddrs: use if_nameindex to enumerate interfaces | rofl0r | 1 | -23/+9 |
| 2013-04-05 | getifaddrs: one less indent level | rofl0r | 1 | -30/+28 |
| 2013-04-05 | getifaddrs: less malloc | rofl0r | 1 | -55/+52 |
| 2013-04-05 | include/ifaddrs.h: add prototypes for get/freeifaddrs | rofl0r | 1 | -0/+3 |
| 2013-04-05 | add getifaddrs•••supports ipv4 and ipv6, but not the "extended" usage where
usage statistics and other info are assigned to ifa_data members
of duplicate entries with AF_PACKET family.
| rofl0r | 2 | -0/+222 |
| 2013-04-05 | net/if.h: add some missing IFF_ constants | rofl0r | 1 | -0/+5 |
| 2013-04-04 | add prototype for dn_skipname | Rich Felker | 1 | -0/+1 |
