| Commit message (Expand) | Author | Files | Lines |
|---|
| 2012-06-29 | replace old and ugly crypt implementation•••the new version is largely the work of Solar Designer, with minor
changes for integration with musl. compared to the old code, text size
is reduced by about 7k, stack space usage by about 70k, and
performance is greatly improved by avoiding expensive calculation of
constant tables on each run.
this version also adds support for extended des-based password hashes,
which allow for unlimited key (password) length and configurable
iteration counts.
i've also published the interface for crypt_r in a new crypt.h header.
especially since this is not a standard interface, i did not feel
compelled to match the glibc abi for the crypt_data structure. the
glibc structure is way too big to allocate on the stack; in fact it's
so big that the first usage may cause the main thread to exceed its
pre-committed stack size of 128k and thus could cause the program to
crash even on systems with overcommit disabled. the only legitimate
use of crypt_data for crypt_r is to store the hash string to return,
so i've reserved 256 bytes, which should be more than sufficient
(longest known password hashes are ~60 characters, and beyond that is
possibly even exceeding some implementations' passwd file field size
limit).
| Rich Felker | 4 | -2574/+1075 |
| 2012-06-25 | fix arm crti/crtn code•••lr must be saved because init/fini-section code from the compiler
clobbers it. this was not a problem when i tested without gcc's
crtbegin/crtend files present, but with them, musl on arm fails to
work (infinite loop in _init).
| Rich Felker | 2 | -0/+4 |
| 2012-06-24 | release notes for 0.9.2 | Rich Felker | 1 | -0/+44 |
| 2012-06-23 | add process_vm_readv and process_vm_writev syscall wrappers•••based on a patch submitted by Kristian L. <email@thexception.net>
| Rich Felker | 2 | -0/+22 |
| 2012-06-23 | update syscall defs to latest kernel ones•••patch submitted by Kristian L. <email@thexception.net>
| Rich Felker | 3 | -0/+38 |
| 2012-06-20 | proper error handling for fcntl F_GETOWN on modern kernels•••on old kernels, there's no way to detect errors; we must assume
negative syscall return values are pgrp ids. but if the F_GETOWN_EX
fcntl works, we can get a reliable answer.
| Rich Felker | 5 | -1/+29 |
| 2012-06-20 | math: fix fma bug on x86 (found by Bruno Haible with gnulib)•••The long double adjustment was wrong:
The usual check is
mant_bits & 0x7ff == 0x400
before doing a mant_bits++ or mant_bits-- adjustment since
this is the only case when rounding an inexact ld80 into
double can go wrong. (only in nearest rounding mode)
After such a check the ++ and -- is ok (the mantissa will end
in 0x401 or 0x3ff).
fma is a bit different (we need to add 3 numbers with correct
rounding: hi_xy + lo_xy + z so we should survive two roundings
at different places without precision loss)
The adjustment in fma only checks for zero low bits
mant_bits & 0x3ff == 0
this way the adjusted value is correct when rounded to
double or *less* precision.
(this is an important piece in the fma puzzle)
Unfortunately in this case the -- is not a correct adjustment
because mant_bits might underflow so further checks are needed
and this was the source of the bug.
| nsz | 1 | -2/+10 |
| 2012-06-20 | fix broken wcwidth tables•••unicode char data has both "W" and "F" wide types and the old table
only included the "W" ones. this omitted U+3000 (ideographic space)
and all the wide-ascii, etc.
| Rich Felker | 1 | -7/+8 |
| 2012-06-20 | support ld80 pseudo-denormal invalid bit patterns; treat them as nan•••this is silly, but it makes apps that read binary junk and interpret
it as ld80 "safer", and it gets gnulib to stop replacing printf...
| Rich Felker | 1 | -2/+5 |
| 2012-06-20 | fix ptsname_r to conform to the upcoming posix requirements•••it should return the error code rather than 0/-1 and setting errno.
| Rich Felker | 2 | -4/+13 |
| 2012-06-20 | fix fwrite return value when full write does not succeed | Rich Felker | 1 | -1/+1 |
| 2012-06-20 | avoid cancellation in pclose•••at the point pclose might receive and act on cancellation, it has
already invalidated the FILE passed to it. thus, per musl's QOI
guarantees about cancellation and resource allocation/deallocation,
it's not a candidate for cancellation.
if it were required to be a cancellation point by posix, we would have
to switch the order of deallocation, but somehow still close the pipe
in order to trigger the child process to exit. i looked into doing
this, but the logic gets ugly, and i'm not sure the semantics are
conformant, so i'd rather just leave it alone unless there's a need to
change it.
| Rich Felker | 1 | -3/+4 |
| 2012-06-20 | fix invalid memory access in pclose | Rich Felker | 1 | -1/+2 |
| 2012-06-20 | make popen cancellation-safe•••close was the only cancellation point called from popen, but it left
popen with major resource leaks if any call to close got cancelled.
the easiest, cheapest fix is just to use a non-cancellable close
function.
| Rich Felker | 1 | -0/+7 |
| 2012-06-20 | popen: handle issues with fd0/1 being closed•••also check for failure of dup2 and abort the child rather than
reading/writing the wrong file.
| Rich Felker | 1 | -3/+3 |
| 2012-06-20 | duplocale: don't crash when called with LC_GLOBAL_LOCALE•••posix has resolved to add this usage; for now, we just avoid writing
anything to the new locale object since it's not used anyway.
| Rich Felker | 1 | -1/+1 |
| 2012-06-20 | make strerror_r behave nicer on failure•••if the buffer is too short, at least return a partial string. this is
helpful if the caller is lazy and does not check for failure. care is
taken to avoid writing anything if the buffer length is zero, and to
always null-terminate when the buffer length is non-zero.
| Rich Felker | 1 | -2/+8 |
| 2012-06-20 | fix another oob pointer arithmetic issue in printf floating point•••this one could never cause any problems unless the compiler/machine
goes to extra trouble to break oob pointer arithmetic, but it's best
to fix it anyway.
| Rich Felker | 1 | -1/+1 |
| 2012-06-20 | minor perror behavior fix•••patch by nsz
| Rich Felker | 1 | -1/+1 |
| 2012-06-19 | fix localeconv values and implementation•••dynamic-allocation of the structure is not valid; it can crash an
application if malloc fails. since localeconv is not specified to have
failure conditions, the object needs to have static storage duration.
need to review whether all the values are right or not still..
| Rich Felker | 1 | -15/+28 |
| 2012-06-19 | fix mistake in length test in getlogin_r•••this was actually dangerously wrong, but presumably nobody uses this
broken function anymore anyway..
| Rich Felker | 1 | -1/+1 |
| 2012-06-19 | fix dummied-out fsync•••if we eventually have build options, it might be nice to make an
option to dummy this out again, in case anybody needs a system-wide
disable for disk/ssd-thrashing, etc. that some daemons do when
logging...
| Rich Felker | 1 | -2/+1 |
| 2012-06-19 | fix dummied-out fdatasync | Rich Felker | 1 | -1/+1 |
| 2012-06-19 | fix pointer overflow bug in floating point printf•••large precision values could cause out-of-bounds pointer arithmetic in
computing the precision cutoff (used to avoid expensive long-precision
arithmetic when the result will be discarded). per the C standard,
this is undefined behavior. one would expect that it works anyway, and
in fact it did in most real-world cases, but it was randomly
(depending on aslr) crashing in i386 binaries running on x86_64
kernels. this is because linux puts the userspace stack near 4GB
(instead of near 3GB) when the kernel is 64-bit, leading to the
out-of-bounds pointer arithmetic overflowing past the end of address
space and giving a very low pointer value, which then compared lower
than a pointer it should have been higher than.
the new code rearranges the arithmetic so that no overflow can occur.
while this bug could crash printf with memory corruption, it's
unlikely to have security impact in real-world applications since the
ability to provide an extremely large field precision value under
attacker-control is required to trigger the bug.
| Rich Felker | 1 | -3/+3 |
