aboutsummaryrefslogtreecommitdiff
path: root/src/linux/chroot.c (unfollow)
Commit message (Expand)AuthorFilesLines
2013-07-20fix uninitialized/stale use of alloc (%m modifier) flag in scanf•••for conversion specifiers, alloc is always set when the specifier is parsed. however, if scanf stops due to mismatching literal text, either an uninitialized (if no conversions have been performed yet) or stale (from the previous conversion) of the flag will be used, possibly causing an invalid pointer to be passed to free when the function returns. Rich Felker2-0/+4
2013-07-19harden realloc/free to detect simple overflows•••the sizes in the header and footer for a chunk should always match. if they don't, the program has definitely invoked undefined behavior, and the most likely cause is a simple overflow, either of a buffer in the block being freed or the one just below it. crashing here should not only improve security of buggy programs, but also aid in debugging, since the crash happens in a context where you have a pointer to the likely-overflowed buffer. Rich Felker1-0/+6
2013-07-19add UIO_MAXIOV macro in sys/uio.h•••while there's no POSIX namespace provision for UIO_* in uio.h, this exact macro name is reserved in XBD 2.2.2. apparently some glibc-centric software expects it to exist, so let's provide it. Rich Felker1-0/+2
2013-07-19improve [f]stat[v]fs functions, and possibly work around old kernels•••the main aim of this patch is to ensure that if not all fields are filled in, they contain zeros, so as not to confuse applications. reportedly some older kernels, including commonly used openvz kernels, lack the f_flags field, resulting in applications reading random junk as the mount flags; the common symptom seems to be wrongly considering the filesystem to be mounted read-only and refusing to operate. glibc has some amazingly ugly fallback code to get the mount flags for old kernels, but having them really is not that important anyway; what matters most is not presenting incorrect flags to the application. I have also aimed to fill in some fields of statvfs that were previously missing, and added code to explicitly zero the reserved space at the end of the structure, which will make things easier in the future if this space someday needs to be used. Rich Felker1-2/+5
2013-07-19change uid_t, gid_t, and id_t to unsigned types•••this change is both to fix one of the remaining type (and thus C++ ABI) mismatches with glibc/LSB and to allow use of the full range of uid and gid values, if so desired. passwd/group access functions were not prepared to deal with unsigned values, so they too have been fixed with this commit. Rich Felker8-24/+38
2013-07-18fix invalid C in new trycppif tests in configure script•••an empty program is not valid and would be reasonable grounds for the compiler to give an error, which would break these tests. Rich Felker1-1/+2
2013-07-18add build system support for arch endian & float abi variantsRich Felker2-1/+33
2013-07-18make the dynamic linker find its path file relative to its own location•••prior to this change, using a non-default syslibdir was impractical on systems where the ordinary library paths contain musl-incompatible library files. the file containing search paths was always taken from /etc, which would either correspond to a system-wide musl installation, or fail to exist at all, resulting in searching of the default library path. the new search strategy is safe even for suid programs because the pathname used comes from the PT_INTERP header of the program being run, rather than any external input. as part of this change, I have also begun differentiating the names of arch variants that differ by endianness or floating point calling convention. the corresponding changes in the build system and and gcc wrapper script (to use an alternate dynamic linker name) for these configurations have not yet been made. Rich Felker7-7/+53
2013-07-18fix off-by-one error in checks for implementation-internal signal numbersRich Felker3-3/+3
2013-07-18fix FILENAME_MAX to match PATH_MAX•••POSIX is not clear on whether it includes the termination, but ISO C requires that it does. the whole concept of this macro is rather useless, but it's better to be correct anyway. Rich Felker1-1/+1
2013-07-17make spacing in x86_64 alltypes.h.sh more uniform with other archs•••patch by Luka Perkov, who noted that all other archs have a newline. Rich Felker1-0/+1
2013-07-17make posix_spawn (and functions that use it) use CLONE_VFORK flag•••this is both a minor scheduling optimization and a workaround for a difficult-to-fix bug in qemu app-level emulation. from the scheduling standpoint, it makes no sense to schedule the parent thread again until the child has exec'd or exited, since the parent will immediately block again waiting for it. on the qemu side, as regular application code running on an underlying libc, qemu cannot make arbitrary clone syscalls itself without confusing the underlying implementation. instead, it breaks them down into either fork-like or pthread_create-like cases. it was treating the code in posix_spawn as pthread_create-like, due to CLONE_VM, which caused horribly wrong behavior: CLONE_FILES broke the synchronization mechanism, CLONE_SIGHAND broke the parent's signals, and CLONE_THREAD caused the child's exec to end the parent -- if it hadn't already crashed. however, qemu special-cases CLONE_VFORK and emulates that with fork, even when CLONE_VM is also specified. this also gives incorrect semantics for code that really needs the memory sharing, but posix_spawn does not make use of the vm sharing except to avoid momentary double commit charge. programs using posix_spawn (including via popen) should now work correctly under qemu app-level emulation. Rich Felker1-1/+2
2013-07-17fix missing argument in variadic syscall macros•••for 0-argument syscalls (1 argument to the macro, the syscall number), the __SYSCALL_NARGS_X macro's ... argument was not satisfied. newer compilers seem to care about this. Rich Felker1-1/+1
2013-07-17fix error code on time conversion overflows•••POSIX mandates EOVERFLOW for this condition. Rich Felker4-4/+4
2013-07-17fix fd leak in file mapping code used in new zoneinfo supportRich Felker1-1/+1
2013-07-17the big time handling overhaul•••this commit has two major user-visible parts: zoneinfo-format time zones are now supported, and overflow handling is intended to be complete in the sense that all functions return a correct result if and only if the result fits in the destination type, and otherwise return an error. also, some noticable bugs in the way DST detection and normalization worked have been fixed, and performance may be better than before, but it has not been tested. Rich Felker18-348/+649
2013-07-13fix omission of dtv setup in static linked programs on TLS variant I archs•••apparently this was never noticed before because the linker normally optimizes dynamic TLS models to non-dynamic ones when static linking, thus eliminating the calls to __tls_get_addr which crash when the dtv is missing. however, some libsupc++ code on ARM was calling __tls_get_addr when static linked and crashing. the reason is unclear to me, but with this issue fixed it should work now anyway. Rich Felker1-1/+1