| Commit message (Expand) | Author | Age | Files | Lines |
|---|
| * | free allocations in clearenv•••This aligns clearenv with the Linux man page by setting 'environ'
rather than '*environ' to NULL, and stops it from leaking entries
allocated by the libc.
| Alexander Monakov | 2017-09-04 | 1 | -2/+6 |
| * | overhaul environment functions•••Rewrite environment access functions to slim down code, fix bugs and
avoid invoking undefined behavior.
* avoid using int-typed iterators where size_t would be correct;
* use strncmp instead of memcmp consistently;
* tighten prologues by invoking __strchrnul;
* handle NULL environ.
putenv:
* handle "=value" input via unsetenv too (will return -1/EINVAL);
* rewrite and simplify __putenv; fix the leak caused by failure to
deallocate entry added by preceding setenv when called from putenv.
setenv:
* move management of libc-allocated entries to this translation unit,
and use no-op weak symbols in putenv/unsetenv;
unsetenv:
* rewrite; this fixes UB caused by testing a free'd pointer against
NULL on entry to subsequent loops.
Not changed:
Failure to extend allocation tracking array (previously __env_map, now
env_alloced) is ignored rather than causing to report -1/ENOMEM to the
caller; the worst-case consequence is leaking this allocation when it
is removed or replaced in a subsequent environment access.
Initially UB in unsetenv was reported by Alexander Cherepanov.
Using a weak alias to avoid pulling in malloc via unsetenv was
suggested by Rich Felker.
| Alexander Monakov | 2017-09-04 | 4 | -81/+86 |
| * | fix erroneous acceptance of f4 9x xx xx code sequences by utf-8 decoder•••the DFA table controlling accepted ranges for the f4 prefix used an
incorrect upper bound of 0xa0 where it should have been 0x90, allowing
such sequences to be accepted and decoded as non-Unicode-scalar values
0x110000 through 0x11ffff.
| Rich Felker | 2017-09-01 | 1 | -1/+1 |
| * | fix erroneous stop before input limit in mbsnrtowcs and wcsnrtombs•••the value computed as an output limit that bounds the amount of input
consumed below the input limit was incorrectly being used as the
actual amount of input consumed. instead, compute the actual amount of
input consumed as a difference of pointers before and after the
conversion.
patch by Mikhail Kremnyov.
| Rich Felker | 2017-08-31 | 2 | -2/+6 |
| * | arm: add HWCAP_ARM_ hwcap macros•••Glibc renamed the linux uapi HWCAP_* macros to HWCAP_ARM_*
so have both variants in case some code depends on it.
(The HWCAP2_ macros are not defined in glibc currently so those
only have the linux uapi variant.)
| Szabolcs Nagy | 2017-08-29 | 1 | -0/+24 |
| * | add a_clz_64 helper function•••counts leading zero bits of a 64bit int, undefined on zero input.
(has nothing to do with atomics, added to atomic.h so target specific
helper functions are together.)
there is a logarithmic generic implementation and another in terms of
a 32bit a_clz_32 on targets where that's available.
| Szabolcs Nagy | 2017-08-29 | 8 | -0/+70 |
| * | s390x: add bits/hwcap.h•••aligned with linux arch/s390/include/asm/elf.h
(these macros should be exported into uapi, but they are not)
| Szabolcs Nagy | 2017-08-29 | 1 | -0/+15 |
| * | move IPPORT_RESERVED from netdb.h to netinet/in.h•••it's in the reserved namespace for the latter, where it seems it was
historically defined, and some programs expect to find it there.
| Rich Felker | 2017-08-29 | 2 | -2/+2 |
| * | add powerpc64 and s390x to list of supported archs in INSTALL file | Rich Felker | 2017-08-29 | 1 | -1/+9 |
| * | fix undefined behavior in memset due to missing sequence points•••patch by Pascal Cuoq.
| Rich Felker | 2017-08-29 | 1 | -4/+8 |
| * | __init_libc: add fallbacks for __progname setup•••It is possible for argv[0] to be a null pointer, but the __progname
variable is used to implement functions in src/legacy/err.c that do not
expect it to be null. It is also available to the user via the
program_invocation_name alias as a GNU extension, and the implementation
in Glibc initializes it to a pointer to empty string rather than NULL.
Since argv[0] is usually non-null and it's preferable to keep those
variables in BSS, implement the fallbacks in __init_libc, which also
allows to have an intermediate fallback to AT_EXECFN.
| Alexander Monakov | 2017-08-29 | 1 | -4/+4 |
| * | add SIOCGSTAMPNS socket ioctl macro to ioctl.h•••it is defined in linux asm/sockios.h since commit
ae40eb1ef30ab4120bd3c8b7e3da99ee53d27a23 (linux v2.6.22)
but was missing from musl by accident.
in musl the sockios macros are exposed in sys/ioctl.h together
with other ioctl requests instead of in sys/socket.h because of
namespace rules. (glibc has them in sys/socket.h under _GNU_SOURCE.)
| Szabolcs Nagy | 2017-08-29 | 8 | -0/+8 |
| * | fix mips ioctl macros to match linux asm/sockios.h | Szabolcs Nagy | 2017-08-29 | 3 | -15/+15 |
| * | fix unsynchronized access to FILE structure in fflush(0)•••commit c002668eb0352e619ea7064e4940b397b4a6e68d inadvertently moved
the check for unflushed write buffer outside of the scope of the
existing lock.
| Rich Felker | 2017-08-29 | 1 | -1/+4 |
| * | fix signed overflow in ftok | Daniel Sabogal | 2017-08-12 | 1 | -1/+1 |
| * | fix build failure for sh4a due to missing colon in asm statement•••Due to a missing ":" in an asm() statement, the "memory" clobber is
considered by gcc as an input operand and not a clobber, which causes a
build failure.
| Thomas Petazzoni | 2017-08-11 | 1 | -1/+1 |
| * | trap UB from attempts to join a detached thread•••passing to pthread_join the id of a thread which is not joinable
results in undefined behavior.
in principle the check to trap does not necessarily work if
pthread_detach was called after thread creation, since no effort is
made here to synchronize access to t->detached, but the check is
well-defined and harmless for callers which did not invoke UB, and
likely to help catch erroneous code that would otherwise mysteriously
hang.
patch by William Pitcock.
| Rich Felker | 2017-08-11 | 1 | -0/+1 |
| * | ppc64: fix setjmp/longjmp handling of TOC pointer•••The TOC pointer is constant within a single dso, but needs to be saved
and restored around cross-dso calls. The PLT stub saves it to the
caller's stack frame, and the linker adds code to the caller to restore
it.
With a local call, as within a single dso or with static linking, this
doesn't happen and the TOC pointer is always in r2. Therefore,
setjmp/longjmp need to save/restore the TOC pointer from/to different
locations depending on whether the call to setjmp was a local or non-local
call.
It is always safe for longjmp to restore to both r2 and the caller's stack.
If the call to setjmp was local, and only r2 matters and the stack location
will be ignored, but is required by the ABI to be reserved for the TOC
pointer. If the call was non-local, then only the stack location matters,
and whatever is restored into r2 will be clobbered anyway when the caller
reloads r2 from the stack.
A little extra care is required for sigsetjmp, because it uses setjmp
internally. After the second return from this setjmp call, r2 will contain
the caller's TOC pointer instead of libc's TOC pointer. We need to save
and restore the correct libc pointer before we can tail call to
__sigsetjmp_tail.
| Bobby Bingham | 2017-08-11 | 3 | -17/+39 |
| * | qsort: add a short comment about the algorithm | Leah Neukirchen | 2017-08-11 | 1 | -0/+3 |
| * | disable global visibility override hack (vis.h) by default•••neither current compilers nor linkers treat protected visibility the
way I expected, as having fixed source-level semantics rather than
being dependent on target-specific ABI details, and change seems
unlikely. while the use here does not actually depend on the specific
semantics, at least some versions of some linkers, especially lld,
refuse to allow linking to a libc.so where the symbols have protected
visibility. this cannot be detected at configure-time because linking
libc.so itself works fine, and because even if we could test linking
an application against libc.so successfully, we could not justifiably
assume that the same linker used to link libc.so would also be used
later to link applications.
disable the vis.h hack by default at the configure level, but add an
explicit "auto" option to request the old configure-time detection
rather than just removing it. this leaves it easy to evaluate whether
it actually resulted in significant size or performance benefits while
ensuring that out-of-the-box builds are not unlinkable for some users.
fortunately, preliminary evaluation suggests that at least x86_64,
arm, and aarch64 don't suffer at all from the change, and impact on
other archs is low. if low is not low enough, it should not be hard to
analyze where the significant PLT call ABI costs are present and
mitigate them without the hack.
| Rich Felker | 2017-08-11 | 1 | -2/+3 |
| * | add _NL_LOCALE_NAME extension to nl_langinfo•••since setlocale(cat, NULL) is required to return the setting for the
global locale, there is no standard mechanism to obtain the name of
the currently active thread-local locale set by uselocale. this makes
it impossible for application/library software to load appropriate
translations, etc. unless using the gettext implementation provided by
libc, which has privileged access to libc internals.
to fill this gap, glibc introduced the _NL_LOCALE_NAME macro which can
be used with nl_langinfo to obtain the name. GNU gettext/gnulib code
already use this functionality on glibc, and can easily be adapted to
make use of it on non-glibc systems if it's available; for other
systems they poke at locale implementation internals, which we want to
avoid. this patch provides a compatible interface to the one glibc
introduced.
| Rich Felker | 2017-07-31 | 2 | -0/+10 |
| * | fix missing volatile qualifier on lock in __get_locale | Jens Gustedt | 2017-07-04 | 1 | -1/+1 |
| * | remove ineffective compiler assist from printf•••The switch statement has no 'default:' case and the function ends
immediately following the switch, so the extra comparison did not
communicate any extra information to the compiler.
| Alexander Monakov | 2017-07-04 | 2 | -4/+0 |
| * | fix undefined behavior in ptrace | Alexander Monakov | 2017-07-04 | 1 | -2/+6 |
| * | unify the use of FUTEX_PRIVATE•••The flag 1<<7 is used in several places for different purposes that are
not always easy to distinguish. Mark those usages that correspond to the
flag that is used by the kernel for futexes.
| Jens Gustedt | 2017-07-04 | 4 | -4/+4 |
| * | fix undefined behavior in free | Alexander Monakov | 2017-07-04 | 1 | -2/+3 |
| * | reapply va_arg hacks removal to wprintf•••commit 58e2396a9aa23c132faf4198ca4d779c84955b38 missed that the same
code was duplicated in implementation of vfwprintf.
| Alexander Monakov | 2017-07-04 | 1 | -26/+1 |
| * | remove useless declarations in string.h•••The two functions str{,n}casecmp_l are specified to be declared in
<strings.h> which is already included from <string.h> under _GNU_SOURCE.
| Alexander Monakov | 2017-07-04 | 1 | -2/+0 |
| * | allow specifying argv[0] when invoking a program via ldso command•••previously, the pathname used to load the program was always used as
argv[0]. the default remains the same, but a new --argv0 option can be
used to provide a different value.
| Rich Felker | 2017-07-04 | 1 | -0/+7 |
| * | fix regression in dlopen promotion from RTLD_LOCAL to RTLD_GLOBAL•••commit 4ff234f6cba96403b5de6d29d48a59fd73252040 inadvertently removed
the logic to do this when changing the representation of global
status.
| Rich Felker | 2017-07-04 | 1 | -1/+6 |
| * | ldso: avoid spurious & possible erroneous work for libs with no deps•••a null pointer for a library's deps list was ambiguous: it could
indicate either no dependencies or that the dependency list had not
yet been populated. inability to distinguish could lead to spurious
work when dlopen is called multiple times on a library with no deps,
and due to related bugs, could actually cause other libraries to
falsely appear as dependencies, translating into false positives for
dlsym.
avoid the problem by always initializing the deps pointer, pointing to
an empty list if there are no deps. rather than wasting memory and
introducing another failure path by allocating an empty list per
library, simply share a global dummy list.
further fixes will be needed for related bugs, and much of this code
may end up being replaced.
| Rich Felker | 2017-07-04 | 1 | -4/+7 |
| * | powerpc64: add single-instruction math functions•••while the official elfv2 abi for "powerpc64le" sets power8 as the
baseline isa, we use it for both little and big endian powerpc64
targets and need to maintain compatibility with pre-power8 models. the
instructions for sqrt, fabs, and fma are in the baseline isa; support
for the rest is conditional via predefined isa-level macros.
patch by David Edelsohn.
| Rich Felker | 2017-06-23 | 22 | -0/+290 |
| * | fix clang CFLAGS checks and silence unused argument warnings | Dmitry Golovin | 2017-06-23 | 1 | -0/+8 |
| * | s390x: add single-instruction math functions•••these were introduced in z196 and not available in the baseline (z900)
ISA level. use __HTM__ as an alternate indicator for ISA level, since
gcc did not define __ARCH__ until 7.x.
patch by David Edelsohn.
| Rich Felker | 2017-06-23 | 24 | -0/+360 |
| * | fix arm run-time abi string functions•••in arm rtabi these __aeabi_* functions have special abi (they are
only allowed to clobber r0,r1,r2,r3,ip,lr,cpsr), so they cannot
be simple wrappers around normal string functions (which may
clobber other registers), the safest solution is to write them in
asm, a minimalistic implementation works because these are not
supposed to be emitted by compilers or used in general.
| Szabolcs Nagy | 2017-06-22 | 6 | -36/+76 |
| * | fix regression in getspnam[_r] error code for insufficient buffer size•••commit 2d7d05f031e014068a61d3076c6178513395d2ae wrongly changed ERANGE
to EINVAL, likely as the result of copy-and-paste error.
| Rich Felker | 2017-06-21 | 1 | -1/+1 |
| * | fix omission of microblaze user.h definitions | Rich Felker | 2017-06-21 | 1 | -1/+25 |
| * | fix iconv conversions for iso88592-iso885916•••commit 97bd6b09dbe7478d5a90a06ecd9e5b59389d8eb9 refactored the table
lookup into a function and introduced an error in index computation.
the error caused garbage to be read from the table if the given charmap
had a non-zero number of elided entries.
| Bartosz Brachaczek | 2017-06-20 | 1 | -1/+1 |
| * | handle errors from localtime_r in ctime_r•••POSIX requires ctime_r return a null pointer on failure, which can
occur if the input time_t value is not representable in broken down
form.
based on patch by Alexander Monakov.
| Rich Felker | 2017-06-20 | 1 | -3/+2 |
| * | set errno when getpw*_r, getgr*_r, and getspnam_r fail•••these functions return an error code, and are not explicitly
documented to set errno, but they are nonstandard and the historical
implementations do set errno as well, and some applications expect
this behavior. do likewise for compatibility.
patch by Rudolph Pereira.
| Rich Felker | 2017-06-15 | 3 | -3/+7 |
| * | handle localtime errors in ctime•••ctime passes the result from localtime directly to asctime. But in case
of error, localtime returns 0. This causes an error (NULL pointer
dereference) in asctime.
based on patch by Omer Anson.
| Rich Felker | 2017-06-15 | 1 | -1/+3 |
| * | handle mremap failure in realloc of mmap-serviced allocations•••mremap seems to always fail on nommu, and on some non-Linux
implementations of the Linux syscall API, it at least fails to
increase allocation size, and may fail to move (i.e. defragment) the
existing mapping when shrinking it too. instead of failing realloc or
leaving an over-sized allocation that may waste a large amount of
memory, fallback to malloc-memcpy-free if mremap fails.
| Rich Felker | 2017-06-15 | 1 | -1/+2 |
| * | getdate: correctly specify error number•••POSIX defines getdate error #5 as:
"An I/O error is encountered while reading the template file."
POSIX defines getdate error #7 as:
"There is no line in the template that matches the input."
This change correctly disambiguates between the two error conditions.
| A. Wilcox | 2017-06-14 | 1 | -1/+2 |
| * | catopen: set errno to EOPNOTSUPP•••Per 1003.1-2008 (2016 ed.), catopen must set errno on failure.
We set errno to EOPNOTSUPP because musl does not currently support
message catalogues.
| A. Wilcox | 2017-06-14 | 1 | -0/+2 |
| * | fix glob failure to match plain "/" to root directory•••the check to prevent matching empty string wrongly blocked matching
of "/" due to checking emptiness after stripping leading slashes
rather than checking the full original argument string.
simplified from patch by Julien Ramseier.
| Rich Felker | 2017-06-08 | 1 | -1/+1 |
| * | use hard-coded sh4a atomic opcodes to avoid linker errors on sh•••when using the sh4a opcodes, the assembler tags the resulting object
file as requiring sh4a. the linker then refuses to (static) link it
with object files marked as requiring j2, since there is no isa level
that includes both sh4a and j2 instructions.
| Rich Felker | 2017-06-08 | 1 | -4/+4 |
| * | towupper/towlower: fast path for ascii chars•••Make a fast path for ascii chars which is assumed to be the most common
case. This has significant performance benefit on xml json and similar
| Natanael Copa | 2017-05-31 | 1 | -3/+3 |
| * | remove long-obsolete clang workarounds from mips* syscall_arch.h files•••at one point, clang reportedly failed to support the asm register
constraints needed for inline syscalls. versions of clang that old
have much bigger problems that preclude using them to compile musl
libc.
| Rich Felker | 2017-05-31 | 3 | -157/+0 |
| * | fix fstatat syscall on mips64•••mips64 requires 'struct stat' conversion due to incorrect 32-bit
fields where time_t should be in the kernel version of the structure.
syscall_arch.h already performed the correct translation for stat,
fstat, and lstat syscalls, but omitted special handling for fstatat.
| Rich Felker | 2017-05-31 | 1 | -3/+22 |
| * | fix fchown fallback on arches without chown(2)•••The flags argument was missing, causing uninitalized data to be passed
to fchownat(2). The correct value of flags should match the fallback for
chown(3).
| Samuel Holland | 2017-05-27 | 1 | -1/+1 |
