From 4ef63c9c0db77925ab91b95237f9e3802c4710a4 Mon Sep 17 00:00:00 2001 From: Joshua Hull Date: Fri, 2 Sep 2022 02:45:11 +0000 Subject: Rollback on constraint failure (#1071) Always rollback on a commit error --- sqlite3.go | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'sqlite3.go') diff --git a/sqlite3.go b/sqlite3.go index e037857..9c0f4d8 100644 --- a/sqlite3.go +++ b/sqlite3.go @@ -494,10 +494,12 @@ func (ai *aggInfo) Done(ctx *C.sqlite3_context) { // Commit transaction. func (tx *SQLiteTx) Commit() error { _, err := tx.c.exec(context.Background(), "COMMIT", nil) - if err != nil && err.(Error).Code == C.SQLITE_BUSY { - // sqlite3 will leave the transaction open in this scenario. + if err != nil { + // sqlite3 may leave the transaction open in this scenario. // However, database/sql considers the transaction complete once we // return from Commit() - we must clean up to honour its semantics. + // We don't know if the ROLLBACK is strictly necessary, but according + // to sqlite's docs, there is no harm in calling ROLLBACK unnecessarily. tx.c.exec(context.Background(), "ROLLBACK", nil) } return err -- cgit v1.2.3