From 575c3a508197c696843ea4f15850c71b984c1e7e Mon Sep 17 00:00:00 2001 From: EuAndreh Date: Sat, 12 Jun 2021 17:37:14 -0300 Subject: TODOs.md: Mark #task-fd654661-fa97-83db-1d49-83a66866ccfa as DONE --- TODOs.md | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) (limited to 'TODOs.md') diff --git a/TODOs.md b/TODOs.md index 037c499..7b74139 100644 --- a/TODOs.md +++ b/TODOs.md @@ -14,7 +14,21 @@ [`a9022eb2f72efd9b99212a057df33cba762cd13b`](https://git.euandreh.xyz/git-permalink/commit/?id=a9022eb2f72efd9b99212a057df33cba762cd13b). - TODO in 2021-06-12 -## TODO Write tests {#task-fd654661-fa97-83db-1d49-83a66866ccfa} +## DONE Write tests {#task-fd654661-fa97-83db-1d49-83a66866ccfa} +- DONE in 2021-06-12 + + I didn't find a simple way to test without getting too much into the weeds with mocking Git, and I don't think it is worth it. + + The tests I created are actually just exercising the help and versions flags, and asserting that other flags are ignored. + For effectiveness this is pretty shallow and pretty useless, but I'm fine with the state of not testing the core functionality. + + To do that it would require me to split `src/git-permalink.sh` into two files, one with the function definitions and the other as a runner. + But then I would have to glue them together on the `install` target, and more similar complications. + + Given all that, I chose not to write more tests, and call this done. + + Done in + [`50a7c011274359ef058d30be87b9d29ca4fd06ed`](https://git.euandreh.xyz/git-permalink/commit/?id=50a7c011274359ef058d30be87b9d29ca4fd06ed). - TODO in 2021-06-12 ## TODO Write manpage {#task-6e6f917f-26ad-09fd-9a09-84b5df0f3ea4} -- cgit v1.2.3