| Commit message (Collapse) | Author | Age | Files | Lines |
|---|
| |
|
|
|
| |
Mostly to avoid the conflict of the ".sh" built-in rule in the
Makefile.
|
| |
|
|
| |
git-permalink|sh src/git-permalink.sh|g'
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
| |
The issue wan't with getopts but with my usage of it (well, now that's
obvious that the problem wouldn't be in the implementation, but on how
I was using).
The problem was on:
1) my confusion on when and where to "shift";
2) make sure to look for the "--help" and "--version" long flags before
getopts, because it doesn't know about long flags.
Those fixed, the tests are now working again.
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The choice of implementation was very basic: Use strings in the script
itself rather than relying on external tools.
Compared to a compiled C program using, say, gettext.3, an sh script
could also depend on it, but at runtime. An equivalent C code would
require the gettext.3 dependency, but at compile time. After
compilation, the code required for doing the translation is already on
the binary, while an sh script would need gettext.1 to run gettext.1
commands while it executes, such as "gettext -s 'MSG_ABC'".
Bash has a very appealing feature: using $"" does a lookup and
translates the string. In other words, $"" runs gettext for you,
without the script requiring gettext.1, just Bash.
As tempting as it was, I chose not to rely on Bash. I preferred the
cost of an ad-hoc solution over requiring Bash over POSIX sh.
The final solution is simple enough for the git-permalink.1 program,
but wouldn't scale for bigger scripts. Strings are placed together for
translation, and no external tool is used for this.
Due to the way that strings are now given to printf.1, ShellCheck
complains a lot about those strings, alonside saying that the
string translation variables are unused. They actually are used, but
hidden behind an eval.
Overall I'm satisfied with the solution, but I probably won't follow
the same path for the manpages, and will choose something like po4a for
it, instead.
|
| |
|
|
|
|
|
|
| |
The test that was removed relies on how the repository was clone.
For example, the CI clone the repository as a remote folder, and uses
that for the origin remote. The test fails because of that, and
instead of trying to fix it, I removed it.
|
| |
|
|
|
|
|
| |
This reverts commit d3faf9644490a191a16c148a3f4f865b730e5188.
The file was not actually unused, but used in tests to avoid side
effects when running them.
|
| | |
|
| | |
|
| | |
|
| |
|
