From 44b1e103b4d3a24aee89587ef302891e9f9c3807 Mon Sep 17 00:00:00 2001 From: EuAndreh Date: Fri, 17 Feb 2023 15:07:30 -0300 Subject: bin/: Use explicit "--" separator for assert-arg usages In order to prevent legitimate cases to fail as errors, such as: NUM='-10' eval "$(assert-arg "$NUM" '-n NUM')" To prevent assert-arg(1) from treating "-10" as the options "-1 and -0, they need to be put after the "--" separator. This way, all usages of assert-arg(1) that had its first argument as a variable were adapted, and the usage and examples of assert-arg itself were updated to encourage this best practice. --- bin/without-env | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'bin/without-env') diff --git a/bin/without-env b/bin/without-env index fd9d1e8..57c2d2e 100755 --- a/bin/without-env +++ b/bin/without-env @@ -57,8 +57,8 @@ while getopts 'h' flag; do done shift $((OPTIND - 1)) -eval "$(assert-arg "${1:-}" 'ENVVAR')" -eval "$(assert-arg "${2:-}" 'PATH')" +eval "$(assert-arg -- "${1:-}" 'ENVVAR')" +eval "$(assert-arg -- "${2:-}" 'PATH')" eval "export $1=\"\$(echo \"\$$1\" | sed \"s|\$2:||g\")\"" shift # drop $1 -- cgit v1.2.3