From 44b1e103b4d3a24aee89587ef302891e9f9c3807 Mon Sep 17 00:00:00 2001 From: EuAndreh Date: Fri, 17 Feb 2023 15:07:30 -0300 Subject: bin/: Use explicit "--" separator for assert-arg usages In order to prevent legitimate cases to fail as errors, such as: NUM='-10' eval "$(assert-arg "$NUM" '-n NUM')" To prevent assert-arg(1) from treating "-10" as the options "-1 and -0, they need to be put after the "--" separator. This way, all usages of assert-arg(1) that had its first argument as a variable were adapted, and the usage and examples of assert-arg itself were updated to encourage this best practice. --- bin/vcs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bin/vcs') diff --git a/bin/vcs b/bin/vcs index 33bae3c..cbb34aa 100755 --- a/bin/vcs +++ b/bin/vcs @@ -232,7 +232,7 @@ done shift $((OPTIND - 1)) ACTION="${1:-}" -eval "$(assert-arg "$ACTION" 'ACTION')" +eval "$(assert-arg -- "$ACTION" 'ACTION')" shift if [ "${1:-}" = '--' ]; then -- cgit v1.2.3