From 0f585358f41a0e6b9e433e36a35c03e9fd9d4c47 Mon Sep 17 00:00:00 2001
From: Ben Johnson <benbjohnson@yahoo.com>
Date: Sun, 22 Jun 2014 09:33:28 -0600
Subject: Change Bucket.NextSequence() to return uint64.

This commit changes NextSequence() to return a uint64 instead of an int. This also
removes the ErrSequenceOverflow error condition since overflowing a uint64 is unlikely.

Fixes #39.
---
 bucket_test.go | 26 ++++----------------------
 1 file changed, 4 insertions(+), 22 deletions(-)

(limited to 'bucket_test.go')

diff --git a/bucket_test.go b/bucket_test.go
index 5a1b81c..fbaaeb6 100644
--- a/bucket_test.go
+++ b/bucket_test.go
@@ -451,15 +451,15 @@ func TestBucket_NextSequence(t *testing.T) {
 			// Make sure sequence increments.
 			seq, err := tx.Bucket([]byte("widgets")).NextSequence()
 			assert.NoError(t, err)
-			assert.Equal(t, seq, 1)
+			assert.Equal(t, seq, uint64(1))
 			seq, err = tx.Bucket([]byte("widgets")).NextSequence()
 			assert.NoError(t, err)
-			assert.Equal(t, seq, 2)
+			assert.Equal(t, seq, uint64(2))
 
 			// Buckets should be separate.
 			seq, err = tx.Bucket([]byte("woojits")).NextSequence()
 			assert.NoError(t, err)
-			assert.Equal(t, seq, 1)
+			assert.Equal(t, seq, uint64(1))
 			return nil
 		})
 	})
@@ -475,31 +475,13 @@ func TestBucket_NextSequence_ReadOnly(t *testing.T) {
 		db.View(func(tx *Tx) error {
 			b := tx.Bucket([]byte("widgets"))
 			i, err := b.NextSequence()
-			assert.Equal(t, i, 0)
+			assert.Equal(t, i, uint64(0))
 			assert.Equal(t, err, ErrTxNotWritable)
 			return nil
 		})
 	})
 }
 
-// Ensure that incrementing past the maximum sequence number will return an error.
-func TestBucket_NextSequence_Overflow(t *testing.T) {
-	withOpenDB(func(db *DB, path string) {
-		db.Update(func(tx *Tx) error {
-			tx.CreateBucket([]byte("widgets"))
-			return nil
-		})
-		db.Update(func(tx *Tx) error {
-			b := tx.Bucket([]byte("widgets"))
-			b.bucket.sequence = uint64(maxInt)
-			seq, err := b.NextSequence()
-			assert.Equal(t, err, ErrSequenceOverflow)
-			assert.Equal(t, seq, 0)
-			return nil
-		})
-	})
-}
-
 // Ensure that retrieving the next sequence for a bucket on a closed database return an error.
 func TestBucket_NextSequence_Closed(t *testing.T) {
 	withOpenDB(func(db *DB, path string) {
-- 
cgit v1.2.3